[PATCH 3/3] eeprom: at25: make FRAM device ID error message more precise

Markus Heidelberg posted 3 patches 1 month, 3 weeks ago
There is a newer version of this series
[PATCH 3/3] eeprom: at25: make FRAM device ID error message more precise
Posted by Markus Heidelberg 1 month, 3 weeks ago
The error description would be wrong in case the "size" Devicetree
property is missing for an FRAM without device ID.

Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
---
 drivers/misc/eeprom/at25.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
index c90150f72836..e2868f7bdb03 100644
--- a/drivers/misc/eeprom/at25.c
+++ b/drivers/misc/eeprom/at25.c
@@ -399,7 +399,7 @@ static int at25_fram_to_chip(struct device *dev, struct spi_eeprom *chip)
 				id[j] = tmp;
 			}
 		if (id[6] != 0xc2) {
-			dev_err(dev, "Error: no Cypress FRAM (id %02x)\n", id[6]);
+			dev_err(dev, "Error: no Cypress FRAM with device ID (manufacturer ID bank 7: %02x)\n", id[6]);
 			return -ENODEV;
 		}
 
-- 
2.43.0
Re: [PATCH 3/3] eeprom: at25: make FRAM device ID error message more precise
Posted by Alexander Sverdlin 1 month, 3 weeks ago
On Thu, 2025-08-14 at 13:15 +0200, Markus Heidelberg wrote:
> The error description would be wrong in case the "size" Devicetree
> property is missing for an FRAM without device ID.
> 
> Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>

> ---
>  drivers/misc/eeprom/at25.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
> index c90150f72836..e2868f7bdb03 100644
> --- a/drivers/misc/eeprom/at25.c
> +++ b/drivers/misc/eeprom/at25.c
> @@ -399,7 +399,7 @@ static int at25_fram_to_chip(struct device *dev, struct spi_eeprom *chip)
>  				id[j] = tmp;
>  			}
>  		if (id[6] != 0xc2) {
> -			dev_err(dev, "Error: no Cypress FRAM (id %02x)\n", id[6]);
> +			dev_err(dev, "Error: no Cypress FRAM with device ID (manufacturer ID bank 7: %02x)\n", id[6]);
>  			return -ENODEV;
>  		}

-- 
Alexander Sverdlin.