[PATCH] lkdtm: fortify: Fix potential NULL dereference on kmalloc failure

Junjie Cao posted 1 patch 1 month, 3 weeks ago
drivers/misc/lkdtm/fortify.c | 8 ++++++++
1 file changed, 8 insertions(+)
[PATCH] lkdtm: fortify: Fix potential NULL dereference on kmalloc failure
Posted by Junjie Cao 1 month, 3 weeks ago
Add missing NULL pointer checks after kmalloc() calls in
lkdtm_FORTIFY_STR_MEMBER() and lkdtm_FORTIFY_MEM_MEMBER() functions.

Signed-off-by: Junjie Cao <junjie.cao@intel.com>
---
 drivers/misc/lkdtm/fortify.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/misc/lkdtm/fortify.c b/drivers/misc/lkdtm/fortify.c
index 015927665678..715598226037 100644
--- a/drivers/misc/lkdtm/fortify.c
+++ b/drivers/misc/lkdtm/fortify.c
@@ -44,6 +44,10 @@ static void lkdtm_FORTIFY_STR_MEMBER(void)
 	char *src;
 
 	src = kmalloc(size, GFP_KERNEL);
+
+	if (src == NULL)
+		return;
+
 	strscpy(src, "over ten bytes", size);
 	size = strlen(src) + 1;
 
@@ -109,6 +113,10 @@ static void lkdtm_FORTIFY_MEM_MEMBER(void)
 	char *src;
 
 	src = kmalloc(size, GFP_KERNEL);
+
+	if (src == NULL)
+		return;
+
 	strscpy(src, "over ten bytes", size);
 	size = strlen(src) + 1;
 
-- 
2.43.0
Re: [PATCH] lkdtm: fortify: Fix potential NULL dereference on kmalloc failure
Posted by Kees Cook 1 month, 1 week ago
On Thu, 14 Aug 2025 14:06:05 +0800, Junjie Cao wrote:
> Add missing NULL pointer checks after kmalloc() calls in
> lkdtm_FORTIFY_STR_MEMBER() and lkdtm_FORTIFY_MEM_MEMBER() functions.
> 
> 

Applied to for-next/hardening, thanks!

[1/1] lkdtm: fortify: Fix potential NULL dereference on kmalloc failure
      https://git.kernel.org/kees/c/a3db14be3e90

Take care,

-- 
Kees Cook