[PATCH v2 0/3] Add interconnect support for Glymur SoC

Raviteja Laggyshetty posted 3 patches 1 month, 2 weeks ago
.../bindings/interconnect/qcom,glymur-rpmh.yaml    |  172 ++
drivers/interconnect/qcom/Kconfig                  |    9 +
drivers/interconnect/qcom/Makefile                 |    2 +
drivers/interconnect/qcom/glymur.c                 | 2543 ++++++++++++++++++++
drivers/interconnect/qcom/icc-rpmh.h               |    2 +-
.../dt-bindings/interconnect/qcom,glymur-rpmh.h    |  205 ++
6 files changed, 2932 insertions(+), 1 deletion(-)
[PATCH v2 0/3] Add interconnect support for Glymur SoC
Posted by Raviteja Laggyshetty 1 month, 2 weeks ago
Add interconnect dt-bindings and driver support for
Qualcomm's next gen compute SoC - Glymur.
Device tree changes aren't part of this series and will be posted
separately after the official announcement of the Glymur SoC.

Changes since v1:
  - Replaced static IDs with dynamic ID allocation in driver [Georgi]
  - Enabled QoS config support for Glymur SoC [Konrad]
  - Updated MAX_PORTS to 4 to support video master QoS programming on
    Glymur SoC.

Raviteja Laggyshetty (2):
  dt-bindings: interconnect: document the RPMh Network-On-Chip
    interconnect in Glymur SoC
  interconnect: qcom: add glymur interconnect provider driver

 .../interconnect/qcom,glymur-rpmh.yaml        |   84 +
 drivers/interconnect/qcom/Kconfig             |    9 +
 drivers/interconnect/qcom/Makefile            |    2 +
 drivers/interconnect/qcom/glymur.c            | 2259 +++++++++++++++++
 drivers/interconnect/qcom/glymur.h            |  185 ++
 .../interconnect/qcom,glymur-rpmh.h           |  205 ++
 6 files changed, 2744 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,glymur-rpmh.yaml
 create mode 100644 drivers/interconnect/qcom/glymur.c
 create mode 100644 drivers/interconnect/qcom/glymur.h
 create mode 100644 include/dt-bindings/interconnect/qcom,glymur-rpmh.h

--
2.34.1

---
Raviteja Laggyshetty (3):
      dt-bindings: interconnect: document the RPMh Network-On-Chip interconnect in Glymur SoC
      interconnect: qcom: icc-rpmh: increase MAX_PORTS to support four QoS ports
      interconnect: qcom: add glymur interconnect provider driver

 .../bindings/interconnect/qcom,glymur-rpmh.yaml    |  172 ++
 drivers/interconnect/qcom/Kconfig                  |    9 +
 drivers/interconnect/qcom/Makefile                 |    2 +
 drivers/interconnect/qcom/glymur.c                 | 2543 ++++++++++++++++++++
 drivers/interconnect/qcom/icc-rpmh.h               |    2 +-
 .../dt-bindings/interconnect/qcom,glymur-rpmh.h    |  205 ++
 6 files changed, 2932 insertions(+), 1 deletion(-)
---
base-commit: b1549501188cc9eba732c25b033df7a53ccc341f
change-id: 20250814-glymur-icc-9c54162bd6f1
prerequisite-change-id: 20250812-glymur-clock-controller-v4-59887f028a7d:v4
prerequisite-patch-id: 3f2811249c8a302f59430e6c66d38f42058c38d9
prerequisite-patch-id: 0f69dae48c7a4c6b0b39d0edc5d5f114ac464e13
prerequisite-patch-id: fa24158f66c7291a63dc20e384d13a44ad008858
prerequisite-patch-id: de42c5bedc98965fb14256108743307f738dc34a
prerequisite-patch-id: f1872a81e0bdf89b2e26397d8eb6dc1ce7eeac1e
prerequisite-patch-id: f8c9dd47ab2e9baaea8acfa0698cd48908ccec47
prerequisite-patch-id: 4d61cfd61bf324419714776a0a5c9686dcb944ea

Best regards,
-- 
Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>
Re: [PATCH v2 0/3] Add interconnect support for Glymur SoC
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On 14/08/2025 16:54, Raviteja Laggyshetty wrote:
> Add interconnect dt-bindings and driver support for
> Qualcomm's next gen compute SoC - Glymur.
> Device tree changes aren't part of this series and will be posted
> separately after the official announcement of the Glymur SoC.


No dependencies explained, so how maintainers can understand that they
CANNOT apply this patch? :/

Nice example of throwing the code over the wall, does not matter it does
not even pass standard checks...

Best regards,
Krzysztof
Re: [PATCH v2 0/3] Add interconnect support for Glymur SoC
Posted by Raviteja Laggyshetty 1 month, 2 weeks ago

On 8/19/2025 7:22 PM, Krzysztof Kozlowski wrote:
> On 14/08/2025 16:54, Raviteja Laggyshetty wrote:
>> Add interconnect dt-bindings and driver support for
>> Qualcomm's next gen compute SoC - Glymur.
>> Device tree changes aren't part of this series and will be posted
>> separately after the official announcement of the Glymur SoC.
> 
> 
> No dependencies explained, so how maintainers can understand that they
> CANNOT apply this patch? :/
> 
> Nice example of throwing the code over the wall, does not matter it does
> not even pass standard checks...
> 

Sorry for the trouble, I have added dependencies using b4 prep
edit-deps option and I tried pulling few older changes using 
shazam command and found that it automatically pulls the dependencies
from prerequisite-patch present in cover letter.

I made sure that dt_binding_checks are passing with dependency picked
into workspace. In future patches, I will make sure to explicitly point 
out the dependency in the cover letter apart from adding it using b4 
options.
Sorry for breaking the dt checker.

Thanks,
Raviteja

> Best regards,
> Krzysztof
Re: [PATCH v2 0/3] Add interconnect support for Glymur SoC
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On 20/08/2025 08:06, Raviteja Laggyshetty wrote:
> 
> 
> On 8/19/2025 7:22 PM, Krzysztof Kozlowski wrote:
>> On 14/08/2025 16:54, Raviteja Laggyshetty wrote:
>>> Add interconnect dt-bindings and driver support for
>>> Qualcomm's next gen compute SoC - Glymur.
>>> Device tree changes aren't part of this series and will be posted
>>> separately after the official announcement of the Glymur SoC.
>>
>>
>> No dependencies explained, so how maintainers can understand that they
>> CANNOT apply this patch? :/
>>
>> Nice example of throwing the code over the wall, does not matter it does
>> not even pass standard checks...
>>
> 
> Sorry for the trouble, I have added dependencies using b4 prep
> edit-deps option and I tried pulling few older changes using 

Please wait for a minute and carefully think about that: did it make
sense? What exactly did you expect?

Interconnect maintainer will pull this patchset and the dependencies
(e.g. clock patches), yes? That's what you expected?

So what about the same patches in the clock tree?

> shazam command and found that it automatically pulls the dependencies
> from prerequisite-patch present in cover letter.
> 
> I made sure that dt_binding_checks are passing with dependency picked

This is not how you should create branches and your instruction how to
work on Glymur included that. :/


Best regards,
Krzysztof