clocksource/drivers/timer-tegra186: don't print superfluous errors

[PATCH] clocksource/drivers/timer-tegra186: don't print superfluous errors

Posted by Wolfram Sang 5 months, 4 weeks ago

The watchdog core will handle error messages already.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/clocksource/timer-tegra186.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/timer-tegra186.c
index e5394f98a02e..b40d7ed37936 100644
--- a/drivers/clocksource/timer-tegra186.c
+++ b/drivers/clocksource/timer-tegra186.c
@@ -328,16 +328,12 @@ static struct tegra186_wdt *tegra186_wdt_create(struct tegra186_timer *tegra,
 	wdt->base.parent = tegra->dev;
 
 	err = watchdog_init_timeout(&wdt->base, 5, tegra->dev);
-	if (err < 0) {
-		dev_err(tegra->dev, "failed to initialize timeout: %d\n", err);
+	if (err < 0)
 		return ERR_PTR(err);
-	}
 
 	err = devm_watchdog_register_device(tegra->dev, &wdt->base);
-	if (err < 0) {
-		dev_err(tegra->dev, "failed to register WDT: %d\n", err);
+	if (err < 0)
 		return ERR_PTR(err);
-	}
 
 	return wdt;
 }
-- 
2.47.2

Re: [PATCH] clocksource/drivers/timer-tegra186: don't print superfluous errors

Posted by Daniel Lezcano 4 months, 3 weeks ago

On 13/08/2025 21:06, Wolfram Sang wrote:
> The watchdog core will handle error messages already.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---

Applied, thanks


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] clocksource/drivers/timer-tegra186: don't print superfluous errors

Posted by Mikko Perttunen 4 months, 3 weeks ago

On Thursday, August 14, 2025 4:06 AM Wolfram Sang wrote:
> The watchdog core will handle error messages already.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/clocksource/timer-tegra186.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/timer-tegra186.c
> index e5394f98a02e..b40d7ed37936 100644
> --- a/drivers/clocksource/timer-tegra186.c
> +++ b/drivers/clocksource/timer-tegra186.c
> @@ -328,16 +328,12 @@ static struct tegra186_wdt *tegra186_wdt_create(struct tegra186_timer *tegra,
>  	wdt->base.parent = tegra->dev;
>  
>  	err = watchdog_init_timeout(&wdt->base, 5, tegra->dev);
> -	if (err < 0) {
> -		dev_err(tegra->dev, "failed to initialize timeout: %d\n", err);
> +	if (err < 0)
>  		return ERR_PTR(err);
> -	}
>  
>  	err = devm_watchdog_register_device(tegra->dev, &wdt->base);
> -	if (err < 0) {
> -		dev_err(tegra->dev, "failed to register WDT: %d\n", err);
> +	if (err < 0)
>  		return ERR_PTR(err);
> -	}
>  
>  	return wdt;
>  }
> 

Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>