[PATCH net-next] net: dsa: realtek: remove unnecessary file, dentry, inode declarations

Vladimir Oltean posted 1 patch 1 month, 3 weeks ago
drivers/net/dsa/realtek/realtek.h | 3 ---
1 file changed, 3 deletions(-)
[PATCH net-next] net: dsa: realtek: remove unnecessary file, dentry, inode declarations
Posted by Vladimir Oltean 1 month, 3 weeks ago
These are present since commit d8652956cf37 ("net: dsa: realtek-smi: Add
Realtek SMI driver") and never needed. Apparently the driver was not
cleaned up sufficiently for submission.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/dsa/realtek/realtek.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/dsa/realtek/realtek.h b/drivers/net/dsa/realtek/realtek.h
index 7f652b245b2e..580a7c55d1e8 100644
--- a/drivers/net/dsa/realtek/realtek.h
+++ b/drivers/net/dsa/realtek/realtek.h
@@ -19,9 +19,6 @@
 
 struct phylink_mac_ops;
 struct realtek_ops;
-struct dentry;
-struct inode;
-struct file;
 
 struct rtl8366_mib_counter {
 	unsigned int	base;
-- 
2.43.0
Re: [PATCH net-next] net: dsa: realtek: remove unnecessary file, dentry, inode declarations
Posted by Linus Walleij 1 month, 3 weeks ago
On Wed, Aug 13, 2025 at 8:10 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:

> These are present since commit d8652956cf37 ("net: dsa: realtek-smi: Add
> Realtek SMI driver") and never needed. Apparently the driver was not
> cleaned up sufficiently for submission.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij