treewide: remove unneeded 'fast_io' parameter in regmap_config

[PATCH 13/21] pinctrl: remove unneeded 'fast_io' parameter in regmap_config

Posted by Wolfram Sang 1 month, 3 weeks ago

When using MMIO with regmap, fast_io is implied. No need to set it
again.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
No dependencies, can be applied directly to the subsystem tree. Buildbot is
happy, too.

 drivers/pinctrl/pinctrl-rp1.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c
index dadafc935dbb..6699b36349d0 100644
--- a/drivers/pinctrl/pinctrl-rp1.c
+++ b/drivers/pinctrl/pinctrl-rp1.c
@@ -1627,7 +1627,6 @@ static const struct regmap_config rp1_pinctrl_regmap_cfg = {
 	.reg_bits = 32,
 	.val_bits = 32,
 	.reg_stride = 4,
-	.fast_io = true,
 	.name = "rp1-pinctrl",
 };
 
-- 
2.47.2

Re: [PATCH 13/21] pinctrl: remove unneeded 'fast_io' parameter in regmap_config

Posted by Linus Walleij 1 month, 2 weeks ago

On Wed, Aug 13, 2025 at 6:16 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:

> When using MMIO with regmap, fast_io is implied. No need to set it
> again.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Patch applied, rebased on top of Adrea della Porta's changes
and fixed the two new instances as well.

Yours,
Linus Walleij

Re: [PATCH 13/21] pinctrl: remove unneeded 'fast_io' parameter in regmap_config

Posted by Andrea della Porta 1 month, 2 weeks ago

Hi Linus,

On 14:02 Tue 19 Aug     , Linus Walleij wrote:
> On Wed, Aug 13, 2025 at 6:16 PM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> 
> > When using MMIO with regmap, fast_io is implied. No need to set it
> > again.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Patch applied, rebased on top of Adrea della Porta's changes
> and fixed the two new instances as well.

Many thanks, really appreciated.

Andrea

> 
> Yours,
> Linus Walleij

Re: [PATCH 13/21] pinctrl: remove unneeded 'fast_io' parameter in regmap_config

Posted by Wolfram Sang 1 month, 2 weeks ago

> Patch applied, rebased on top of Adrea della Porta's changes
> and fixed the two new instances as well.

Thanks, Linus, for the additional work.

Re: [PATCH 13/21] pinctrl: remove unneeded 'fast_io' parameter in regmap_config

Posted by Andrea della Porta 1 month, 3 weeks ago

Hi Wolfram,

On 18:14 Wed 13 Aug     , Wolfram Sang wrote:
> When using MMIO with regmap, fast_io is implied. No need to set it
> again.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> No dependencies, can be applied directly to the subsystem tree. Buildbot is
> happy, too.
> 
>  drivers/pinctrl/pinctrl-rp1.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c
> index dadafc935dbb..6699b36349d0 100644
> --- a/drivers/pinctrl/pinctrl-rp1.c
> +++ b/drivers/pinctrl/pinctrl-rp1.c
> @@ -1627,7 +1627,6 @@ static const struct regmap_config rp1_pinctrl_regmap_cfg = {
>  	.reg_bits = 32,
>  	.val_bits = 32,
>  	.reg_stride = 4,
> -	.fast_io = true,
>  	.name = "rp1-pinctrl",
>  };

Looks fine to me, just a little heads up: the following patch
https://lore.kernel.org/all/20250812092618.14270-1-andrea.porta@suse.com/

adds other two regmap_config with fast_io set to true, so we can
get rid of them too. I can do it in my patch in case I have to send a
second revision, or you can amend yours to cope with my changes and set
my patch as a prerequisite. I guess that it's easier for me since
I have only a single patch, while yours is a big patchset so better
to avoid the noise of a second revision.

Many thanks,
Andrea

>  
> -- 
> 2.47.2
>