ALSA: hda: Improve local variable data type in snd_hda_get_num_devices()

[PATCH] ALSA: hda: Improve local variable data type in snd_hda_get_num_devices()

Posted by Thorsten Blum 1 month, 3 weeks ago

Use 'int' instead of 'unsigned int' because the local variable 'parm'
can be negative.

While an unsigned integer is harmless in practice due to the implicit
type conversion, it's safer and more idiomatic to use a signed integer
to properly check for -1.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 sound/hda/common/codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/hda/common/codec.c b/sound/hda/common/codec.c
index eb268d442201..cab479111603 100644
--- a/sound/hda/common/codec.c
+++ b/sound/hda/common/codec.c
@@ -300,7 +300,7 @@ EXPORT_SYMBOL_GPL(snd_hda_get_conn_index);
 unsigned int snd_hda_get_num_devices(struct hda_codec *codec, hda_nid_t nid)
 {
 	unsigned int wcaps = get_wcaps(codec, nid);
-	unsigned int parm;
+	int parm;
 
 	if (!codec->dp_mst || !(wcaps & AC_WCAP_DIGITAL) ||
 	    get_wcaps_type(wcaps) != AC_WID_PIN)
-- 
2.50.1

Re: [PATCH] ALSA: hda: Improve local variable data type in snd_hda_get_num_devices()

Posted by Takashi Iwai 1 month, 3 weeks ago

On Wed, 13 Aug 2025 12:34:16 +0200,
Thorsten Blum wrote:
> 
> Use 'int' instead of 'unsigned int' because the local variable 'parm'
> can be negative.
> 
> While an unsigned integer is harmless in practice due to the implicit
> type conversion, it's safer and more idiomatic to use a signed integer
> to properly check for -1.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Applied now.  Thanks.


Takashi