[PATCH] maple_tree: Remove redundant semicolons

Liao Yuanhong posted 1 patch 1 month, 3 weeks ago
lib/test_maple_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] maple_tree: Remove redundant semicolons
Posted by Liao Yuanhong 1 month, 3 weeks ago
Remove unnecessary semicolons.

Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
 lib/test_maple_tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
index cb3936595b0d..1433ecc854cb 100644
--- a/lib/test_maple_tree.c
+++ b/lib/test_maple_tree.c
@@ -3562,7 +3562,7 @@ static noinline void __init check_state_handling(struct maple_tree *mt)
 	MT_BUG_ON(mt, mas.last != 0x1500);
 	MT_BUG_ON(mt, !mas_is_active(&mas));
 
-	/* find: start ->active on value */;
+	/* find: start ->active on value */
 	mas_set(&mas, 1200);
 	entry = mas_find(&mas, ULONG_MAX);
 	MT_BUG_ON(mt, entry != ptr);
-- 
2.34.1
Re: [PATCH] maple_tree: Remove redundant semicolons
Posted by Liam R. Howlett 1 month, 3 weeks ago
* Liao Yuanhong <liaoyuanhong@vivo.com> [250813 05:46]:
> Remove unnecessary semicolons.

Thanks!

One nit, it would have been good to state that this is a test code
change in the subject.  Usually I use "test_maple_tree:" or something
like "maple_tree: Remove redundant semicolon from test code".

Please mention test in the subject next time.

> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> ---
>  lib/test_maple_tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
> index cb3936595b0d..1433ecc854cb 100644
> --- a/lib/test_maple_tree.c
> +++ b/lib/test_maple_tree.c
> @@ -3562,7 +3562,7 @@ static noinline void __init check_state_handling(struct maple_tree *mt)
>  	MT_BUG_ON(mt, mas.last != 0x1500);
>  	MT_BUG_ON(mt, !mas_is_active(&mas));
>  
> -	/* find: start ->active on value */;
> +	/* find: start ->active on value */
>  	mas_set(&mas, 1200);
>  	entry = mas_find(&mas, ULONG_MAX);
>  	MT_BUG_ON(mt, entry != ptr);
> -- 
> 2.34.1
>
Re: [PATCH] maple_tree: Remove redundant semicolons
Posted by Liao Yuanhong 1 month, 3 weeks ago
On 8/13/2025 10:02 PM, Liam R. Howlett wrote:

> * Liao Yuanhong <liaoyuanhong@vivo.com> [250813 05:46]:
>> Remove unnecessary semicolons.
> Thanks!
>
> One nit, it would have been good to state that this is a test code
> change in the subject.  Usually I use "test_maple_tree:" or something
> like "maple_tree: Remove redundant semicolon from test code".
>
> Please mention test in the subject next time.

OK, I will pay attention to similar submissions next time.


Thanks,

Liao

>
>> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
>
>> ---
>>   lib/test_maple_tree.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
>> index cb3936595b0d..1433ecc854cb 100644
>> --- a/lib/test_maple_tree.c
>> +++ b/lib/test_maple_tree.c
>> @@ -3562,7 +3562,7 @@ static noinline void __init check_state_handling(struct maple_tree *mt)
>>   	MT_BUG_ON(mt, mas.last != 0x1500);
>>   	MT_BUG_ON(mt, !mas_is_active(&mas));
>>   
>> -	/* find: start ->active on value */;
>> +	/* find: start ->active on value */
>>   	mas_set(&mas, 1200);
>>   	entry = mas_find(&mas, ULONG_MAX);
>>   	MT_BUG_ON(mt, entry != ptr);
>> -- 
>> 2.34.1
>>
Re: [PATCH] maple_tree: Remove redundant semicolons
Posted by Dev Jain 1 month, 3 weeks ago
On 13/08/25 3:15 pm, Liao Yuanhong wrote:
> Remove unnecessary semicolons.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
>   lib/test_maple_tree.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
> index cb3936595b0d..1433ecc854cb 100644
> --- a/lib/test_maple_tree.c
> +++ b/lib/test_maple_tree.c
> @@ -3562,7 +3562,7 @@ static noinline void __init check_state_handling(struct maple_tree *mt)
>   	MT_BUG_ON(mt, mas.last != 0x1500);
>   	MT_BUG_ON(mt, !mas_is_active(&mas));
>   
> -	/* find: start ->active on value */;
> +	/* find: start ->active on value */
>   	mas_set(&mas, 1200);
>   	entry = mas_find(&mas, ULONG_MAX);
>   	MT_BUG_ON(mt, entry != ptr);

Reviewed-by: Dev Jain <dev.jain@arm.com>