PCI: hv: Remove unused parameter of hv_msi_free()

[PATCH] PCI: hv: Remove unused parameter of hv_msi_free()

Posted by Nam Cao 4 months, 1 week ago

The 'info' parameter of hv_msi_free() is unused. Delete it.

Signed-off-by: Nam Cao <namcao@linutronix.de>
---
 drivers/pci/controller/pci-hyperv.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
index d2b7e8ea710b..146b43981b27 100644
--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -1680,7 +1680,6 @@ static void hv_int_desc_free(struct hv_pci_dev *hpdev,
 /**
  * hv_msi_free() - Free the MSI.
  * @domain:	The interrupt domain pointer
- * @info:	Extra MSI-related context
  * @irq:	Identifies the IRQ.
  *
  * The Hyper-V parent partition and hypervisor are tracking the
@@ -1688,8 +1687,7 @@ static void hv_int_desc_free(struct hv_pci_dev *hpdev,
  * table up to date.  This callback sends a message that frees
  * the IRT entry and related tracking nonsense.
  */
-static void hv_msi_free(struct irq_domain *domain, struct msi_domain_info *info,
-			unsigned int irq)
+static void hv_msi_free(struct irq_domain *domain, unsigned int irq)
 {
 	struct hv_pcibus_device *hbus;
 	struct hv_pci_dev *hpdev;
@@ -2181,10 +2179,8 @@ static int hv_pcie_domain_alloc(struct irq_domain *d, unsigned int virq, unsigne
 
 static void hv_pcie_domain_free(struct irq_domain *d, unsigned int virq, unsigned int nr_irqs)
 {
-	struct msi_domain_info *info = d->host_data;
-
 	for (int i = 0; i < nr_irqs; i++)
-		hv_msi_free(d, info, virq + i);
+		hv_msi_free(d, virq + i);
 
 	irq_domain_free_irqs_top(d, virq, nr_irqs);
 }
-- 
2.39.5

Re: [PATCH] PCI: hv: Remove unused parameter of hv_msi_free()

Posted by Manivannan Sadhasivam 3 months, 1 week ago

On Wed, 13 Aug 2025 07:53:50 +0200, Nam Cao wrote:
> The 'info' parameter of hv_msi_free() is unused. Delete it.
> 
> 

Applied, thanks!

[1/1] PCI: hv: Remove unused parameter of hv_msi_free()
      commit: ce47f81925ed73f9d27b1a01f07afdb031949c68

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>

Re: [PATCH] PCI: hv: Remove unused parameter of hv_msi_free()

Posted by Wei Liu 4 months, 1 week ago

On Wed, Aug 13, 2025 at 07:53:50AM +0200, Nam Cao wrote:
> The 'info' parameter of hv_msi_free() is unused. Delete it.
> 
> Signed-off-by: Nam Cao <namcao@linutronix.de>

Acked-by: Wei Liu <wei.liu@kernel.org>

I assume this will go through the PCI tree.

> ---
>  drivers/pci/controller/pci-hyperv.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index d2b7e8ea710b..146b43981b27 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -1680,7 +1680,6 @@ static void hv_int_desc_free(struct hv_pci_dev *hpdev,
>  /**
>   * hv_msi_free() - Free the MSI.
>   * @domain:	The interrupt domain pointer
> - * @info:	Extra MSI-related context
>   * @irq:	Identifies the IRQ.
>   *
>   * The Hyper-V parent partition and hypervisor are tracking the
> @@ -1688,8 +1687,7 @@ static void hv_int_desc_free(struct hv_pci_dev *hpdev,
>   * table up to date.  This callback sends a message that frees
>   * the IRT entry and related tracking nonsense.
>   */
> -static void hv_msi_free(struct irq_domain *domain, struct msi_domain_info *info,
> -			unsigned int irq)
> +static void hv_msi_free(struct irq_domain *domain, unsigned int irq)
>  {
>  	struct hv_pcibus_device *hbus;
>  	struct hv_pci_dev *hpdev;
> @@ -2181,10 +2179,8 @@ static int hv_pcie_domain_alloc(struct irq_domain *d, unsigned int virq, unsigne
>  
>  static void hv_pcie_domain_free(struct irq_domain *d, unsigned int virq, unsigned int nr_irqs)
>  {
> -	struct msi_domain_info *info = d->host_data;
> -
>  	for (int i = 0; i < nr_irqs; i++)
> -		hv_msi_free(d, info, virq + i);
> +		hv_msi_free(d, virq + i);
>  
>  	irq_domain_free_irqs_top(d, virq, nr_irqs);
>  }
> -- 
> 2.39.5
>