[PATCH v4 00/13] PCI: dwc: Refactor register access with dw_pcie_clear_and_set_dword helper

Hans Zhang posted 13 patches 1 month, 3 weeks ago
drivers/pci/controller/dwc/pci-dra7xx.c       |  10 +-
drivers/pci/controller/dwc/pci-imx6.c         |  26 ++-
drivers/pci/controller/dwc/pci-meson.c        |  22 +--
drivers/pci/controller/dwc/pcie-armada8k.c    |  48 ++----
drivers/pci/controller/dwc/pcie-bt1.c         |   5 +-
.../controller/dwc/pcie-designware-debugfs.c  |  66 +++-----
.../pci/controller/dwc/pcie-designware-ep.c   |  20 +--
.../pci/controller/dwc/pcie-designware-host.c |  26 +--
drivers/pci/controller/dwc/pcie-designware.c  |  75 ++++-----
drivers/pci/controller/dwc/pcie-designware.h  |  27 +--
drivers/pci/controller/dwc/pcie-dw-rockchip.c |   7 +-
drivers/pci/controller/dwc/pcie-fu740.c       |   5 +-
drivers/pci/controller/dwc/pcie-qcom-common.c |  59 ++++---
drivers/pci/controller/dwc/pcie-qcom-ep.c     |  14 +-
drivers/pci/controller/dwc/pcie-rcar-gen4.c   |  23 +--
drivers/pci/controller/dwc/pcie-tegra194.c    | 158 +++++++-----------
16 files changed, 239 insertions(+), 352 deletions(-)
[PATCH v4 00/13] PCI: dwc: Refactor register access with dw_pcie_clear_and_set_dword helper
Posted by Hans Zhang 1 month, 3 weeks ago
Register bit manipulation in DesignWare PCIe controllers currently
uses repetitive read-modify-write sequences across multiple drivers.
This pattern leads to code duplication and increases maintenance
complexity as each driver implements similar logic with minor variations.

This series introduces dw_pcie_clear_and_set_dword() to centralize atomic
register modification. The helper performs read-clear-set-write operations
in a single function, replacing open-coded implementations. Subsequent
patches refactor individual drivers to use this helper, eliminating
redundant code and ensuring consistent bit handling.

The change reduces overall code size by ~350 lines while improving
maintainability. Each controller driver is updated in a separate
patch to preserve bisectability and simplify review.

---
Hi all,

At the beginning, two patches were made, 0001*.patch, and the others were
one patch. After consideration, I still split the patches. If splitting
is not necessary, I will recombine them into two patches in future
versions.


Changes for v4:
- Rebase to v6.17-rc1

Changes for v3:
- patch 0002: s/u32 val = 0;/u32 val; (pcie-designware-debugfs.c -> set_event_number())
- patch 0013: Remove several val = 0. (Mani)
- patch 0013: s/PCIE_PL_CHK_REG_CONTROL_STATUS/0. (Error in copying the code.) (Mani)

Changes for v2:
- Re-send it in the company environment so that the entire patch series is in the 00/13 cover letter. (Bjorn)
- Modify the subject. (Bjorn and Frank)
---

Hans Zhang (13):
  PCI: dwc: Add dw_pcie_clear_and_set_dword() for register bit
    manipulation
  PCI: dwc: Refactor code by using dw_pcie_clear_and_set_dword()
  PCI: dra7xx: Refactor code by using dw_pcie_clear_and_set_dword()
  PCI: imx6: Refactor code by using dw_pcie_clear_and_set_dword()
  PCI: meson: Refactor code by using dw_pcie_clear_and_set_dword()
  PCI: armada8k: Refactor code by using dw_pcie_clear_and_set_dword()
  PCI: bt1: Refactor code by using dw_pcie_clear_and_set_dword()
  PCI: dw-rockchip: Refactor code by using dw_pcie_clear_and_set_dword()
  PCI: fu740: Refactor code by using dw_pcie_clear_and_set_dword()
  PCI: qcom: Refactor code by using dw_pcie_clear_and_set_dword()
  PCI: qcom-ep: Refactor code by using dw_pcie_clear_and_set_dword()
  PCI: rcar-gen4: Refactor code by using dw_pcie_clear_and_set_dword()
  PCI: tegra194: Refactor code by using dw_pcie_clear_and_set_dword()

 drivers/pci/controller/dwc/pci-dra7xx.c       |  10 +-
 drivers/pci/controller/dwc/pci-imx6.c         |  26 ++-
 drivers/pci/controller/dwc/pci-meson.c        |  22 +--
 drivers/pci/controller/dwc/pcie-armada8k.c    |  48 ++----
 drivers/pci/controller/dwc/pcie-bt1.c         |   5 +-
 .../controller/dwc/pcie-designware-debugfs.c  |  66 +++-----
 .../pci/controller/dwc/pcie-designware-ep.c   |  20 +--
 .../pci/controller/dwc/pcie-designware-host.c |  26 +--
 drivers/pci/controller/dwc/pcie-designware.c  |  75 ++++-----
 drivers/pci/controller/dwc/pcie-designware.h  |  27 +--
 drivers/pci/controller/dwc/pcie-dw-rockchip.c |   7 +-
 drivers/pci/controller/dwc/pcie-fu740.c       |   5 +-
 drivers/pci/controller/dwc/pcie-qcom-common.c |  59 ++++---
 drivers/pci/controller/dwc/pcie-qcom-ep.c     |  14 +-
 drivers/pci/controller/dwc/pcie-rcar-gen4.c   |  23 +--
 drivers/pci/controller/dwc/pcie-tegra194.c    | 158 +++++++-----------
 16 files changed, 239 insertions(+), 352 deletions(-)


base-commit: 53e760d8949895390e256e723e7ee46618310361
-- 
2.25.1