[PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support

Rosen Penev posted 3 patches 1 month, 3 weeks ago
There is a newer version of this series
.../bindings/net/wireless/qca,ath9k.yaml           | 14 ++++++++++++++
arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts   | 10 +++++-----
arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts     | 10 ++++------
arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts        | 10 ++++------
drivers/net/wireless/ath/ath9k/init.c              | 11 +++++++++++
5 files changed, 38 insertions(+), 17 deletions(-)
[PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support
Posted by Rosen Penev 1 month, 3 weeks ago
A port of the prior platform code to use OF.

v2: use reg instead of led-sources

Rosen Penev (3):
  dt-bindings: net: wireless: ath9k: add led bindings
  wifi: ath9k: ahb: add led pin OF support
  mips: qca: use led-sources for WMAC LED

 .../bindings/net/wireless/qca,ath9k.yaml           | 14 ++++++++++++++
 arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts   | 10 +++++-----
 arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts     | 10 ++++------
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts        | 10 ++++------
 drivers/net/wireless/ath/ath9k/init.c              | 11 +++++++++++
 5 files changed, 38 insertions(+), 17 deletions(-)

-- 
2.50.1
Re: [PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support
Posted by Krzysztof Kozlowski 1 month, 3 weeks ago
On 12/08/2025 21:23, Rosen Penev wrote:
> A port of the prior platform code to use OF.
> 
> v2: use reg instead of led-sources

Where? Really, where? There is no reg in the binding at all. There is
led-sources, though. Also many other things got changed, the binding is
completely different and nothing in changelog explains that.

Best regards,
Krzysztof
Re: [PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support
Posted by Rosen Penev 1 month, 3 weeks ago
On Wed, Aug 13, 2025 at 1:18 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 12/08/2025 21:23, Rosen Penev wrote:
> > A port of the prior platform code to use OF.
> >
> > v2: use reg instead of led-sources
>
> Where? Really, where? There is no reg in the binding at all. There is
> led-sources, though. Also many other things got changed, the binding is
> completely different and nothing in changelog explains that.
Yeah. The initial was copy/paste from mt76 driver. But then on review
I was told to change led-sources to reg and did not completely change
that in the patchset.
>
> Best regards,
> Krzysztof