[PATCH] selftests/bpf: Fix typo in kprobe_multi_test.c

Shubham Sharma posted 1 patch 1 month, 3 weeks ago
tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] selftests/bpf: Fix typo in kprobe_multi_test.c
Posted by Shubham Sharma 1 month, 3 weeks ago
Fixed a spelling mistake:
- comparision -> comparison

Signed-off-by: Shubham Sharma <slopixelz@gmail.com>
---
 tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
index e19ef509ebf8..f377bea0b82d 100644
--- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
+++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
@@ -463,7 +463,7 @@ static bool skip_entry(char *name)
 	return false;
 }
 
-/* Do comparision by ignoring '.llvm.<hash>' suffixes. */
+/* Do comparison by ignoring '.llvm.<hash>' suffixes. */
 static int compare_name(const char *name1, const char *name2)
 {
 	const char *res1, *res2;
-- 
2.43.0
Re: [PATCH] selftests/bpf: Fix typo in kprobe_multi_test.c
Posted by Andrii Nakryiko 1 month, 3 weeks ago
On Tue, Aug 12, 2025 at 8:37 AM Shubham Sharma <slopixelz@gmail.com> wrote:
>
> Fixed a spelling mistake:
> - comparision -> comparison
>
> Signed-off-by: Shubham Sharma <slopixelz@gmail.com>
> ---
>  tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> index e19ef509ebf8..f377bea0b82d 100644
> --- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> @@ -463,7 +463,7 @@ static bool skip_entry(char *name)
>         return false;
>  }
>
> -/* Do comparision by ignoring '.llvm.<hash>' suffixes. */
> +/* Do comparison by ignoring '.llvm.<hash>' suffixes. */

Is this the only typo in the entire BPF selftests? If we are doing
single character comment fixes, let's do it as one bigger pass,
instead of tons of tiny patches?

pw-bot: cr


>  static int compare_name(const char *name1, const char *name2)
>  {
>         const char *res1, *res2;
> --
> 2.43.0
>
Re: [PATCH] selftests/bpf: Fix typo in kprobe_multi_test.c
Posted by Shubham Sharma 1 month, 3 weeks ago
On Thu, Aug 14, 2025 at 3:35 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Tue, Aug 12, 2025 at 8:37 AM Shubham Sharma <slopixelz@gmail.com> wrote:
> >
> > Fixed a spelling mistake:
> > - comparision -> comparison
> >
> > Signed-off-by: Shubham Sharma <slopixelz@gmail.com>
> > ---
> >  tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > index e19ef509ebf8..f377bea0b82d 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > @@ -463,7 +463,7 @@ static bool skip_entry(char *name)
> >         return false;
> >  }
> >
> > -/* Do comparision by ignoring '.llvm.<hash>' suffixes. */
> > +/* Do comparison by ignoring '.llvm.<hash>' suffixes. */
>
> Is this the only typo in the entire BPF selftests? If we are doing
> single character comment fixes, let's do it as one bigger pass,
> instead of tons of tiny patches?
>
> pw-bot: cr
>
>
> >  static int compare_name(const char *name1, const char *name2)
> >  {
> >         const char *res1, *res2;
> > --
> > 2.43.0
> >


Thank you for the feedback. I understand that small, single-character
fixes are better grouped into a larger patch to avoid multiple tiny
commits.
I’ll review the BPF selftests code for similar typos and send a
combined patch instead.

Thanks,
Shubham Sharma