[PATCH v3 0/7] ALSA: usb-audio: Add driver for TASCAM US-144MKII

Šerif Rami posted 7 patches 1 month, 3 weeks ago
There is a newer version of this series
sound/usb/Kconfig                    |  12 +
sound/usb/usx2y/Makefile             |   2 +
sound/usb/usx2y/us122l.c             |   6 -
sound/usb/usx2y/us144mkii.c          | 618 +++++++++++++++++++++++++++
sound/usb/usx2y/us144mkii.h          | 368 ++++++++++++++++
sound/usb/usx2y/us144mkii_capture.c  | 325 ++++++++++++++
sound/usb/usx2y/us144mkii_controls.c | 444 +++++++++++++++++++
sound/usb/usx2y/us144mkii_midi.c     | 401 +++++++++++++++++
sound/usb/usx2y/us144mkii_pcm.c      | 372 ++++++++++++++++
sound/usb/usx2y/us144mkii_pcm.h      | 165 +++++++
sound/usb/usx2y/us144mkii_playback.c | 463 ++++++++++++++++++++
11 files changed, 3170 insertions(+), 6 deletions(-)
create mode 100644 sound/usb/usx2y/us144mkii.c
create mode 100644 sound/usb/usx2y/us144mkii.h
create mode 100644 sound/usb/usx2y/us144mkii_capture.c
create mode 100644 sound/usb/usx2y/us144mkii_controls.c
create mode 100644 sound/usb/usx2y/us144mkii_midi.c
create mode 100644 sound/usb/usx2y/us144mkii_pcm.c
create mode 100644 sound/usb/usx2y/us144mkii_pcm.h
create mode 100644 sound/usb/usx2y/us144mkii_playback.c
[PATCH v3 0/7] ALSA: usb-audio: Add driver for TASCAM US-144MKII
Posted by Šerif Rami 1 month, 3 weeks ago
Hi there,

I'm sorry if if this is inproper way to submit new version of the patches.
The v2 submission got mixed up with unusable patches.
Hopefully this isn't an issue for the verification of the changes and further
review.

Thanks,

This is v3 of the patch series to add a new driver
for the TASCAM US-144MKII USB audio interface.

Changes in v3
  - Corrected v2 invalid patches order
  The v2 submission included mix of patches for v2 that were unusable.
  These new patches are valid now.

Changes in v2:
  - Patch 1: Dropped blank line, initialized `__free(kfree)` variable to
     NULL, and fixed `struct tascam_card` indentation.
  - Patch 2: Corrected indentation in `us144mkii.h`.
  - Patch 3: Changed `fpoInitPattern` to `fpo_init_pattern` (snake_case),
     initialized `__free(kfree)` variable, and replaced
     `guard(spinlock_irqsave)` with `scoped_guard()`.
  - Patch 5: Updated control names to standard "Playback Source" and
     "Capture Source" formats, and initialized `__free(kfree)` variable to NULL.
  - Patch 6: Re-organized code style alignments into previous patches.
  - Patch 7: Fixed trailing whitespace warning.

Šerif Rami (7):
  ALSA: usb-audio: Add initial driver for TASCAM US-144MKII
  ALSA: usb-audio: us144mkii: Add PCM core infrastructure
  ALSA: usb-audio: us144mkii: Implement audio playback and feedback
  ALSA: usb-audio: us144mkii: Implement audio capture and decoding
  ALSA: usb-audio: us144mkii: Add MIDI support and mixer controls
  ALSA: usb-audio: us144mkii: Add deep sleep command
  ALSA: usb-audio: Add infrastructure for TASCAM US-144MKII

 sound/usb/Kconfig                    |  12 +
 sound/usb/usx2y/Makefile             |   2 +
 sound/usb/usx2y/us122l.c             |   6 -
 sound/usb/usx2y/us144mkii.c          | 618 +++++++++++++++++++++++++++
 sound/usb/usx2y/us144mkii.h          | 368 ++++++++++++++++
 sound/usb/usx2y/us144mkii_capture.c  | 325 ++++++++++++++
 sound/usb/usx2y/us144mkii_controls.c | 444 +++++++++++++++++++
 sound/usb/usx2y/us144mkii_midi.c     | 401 +++++++++++++++++
 sound/usb/usx2y/us144mkii_pcm.c      | 372 ++++++++++++++++
 sound/usb/usx2y/us144mkii_pcm.h      | 165 +++++++
 sound/usb/usx2y/us144mkii_playback.c | 463 ++++++++++++++++++++
 11 files changed, 3170 insertions(+), 6 deletions(-)
 create mode 100644 sound/usb/usx2y/us144mkii.c
 create mode 100644 sound/usb/usx2y/us144mkii.h
 create mode 100644 sound/usb/usx2y/us144mkii_capture.c
 create mode 100644 sound/usb/usx2y/us144mkii_controls.c
 create mode 100644 sound/usb/usx2y/us144mkii_midi.c
 create mode 100644 sound/usb/usx2y/us144mkii_pcm.c
 create mode 100644 sound/usb/usx2y/us144mkii_pcm.h
 create mode 100644 sound/usb/usx2y/us144mkii_playback.c

-- 
2.39.5

Re: [PATCH v3 0/7] ALSA: usb-audio: Add driver for TASCAM US-144MKII
Posted by Takashi Iwai 1 month, 3 weeks ago
On Tue, 12 Aug 2025 15:22:02 +0200,
Šerif Rami wrote:
> 
> Hi there,
> 
> I'm sorry if if this is inproper way to submit new version of the patches.
> The v2 submission got mixed up with unusable patches.
> Hopefully this isn't an issue for the verification of the changes and further
> review.

The patches look mostly OK, but there are a few remaining issues.
Looking forward to seeing v4.

Also, at the submission of v4, please don't hang on the previous
thread, but rather open a new thread.  It'll make easier to follow the
new series.


Thanks!

Takashi