pinctrl: bcm: use PTR_ERR_OR_ZERO() to simplify code

[PATCH] pinctrl: bcm: use PTR_ERR_OR_ZERO() to simplify code

Xichao Zhao posted 1 patch 1 month, 3 weeks ago

Download mbox

drivers/pinctrl/bcm/pinctrl-bcm6358.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Expand all Fold all

[PATCH] pinctrl: bcm: use PTR_ERR_OR_ZERO() to simplify code

Posted by Xichao Zhao 1 month, 3 weeks ago

Use the standard error pointer macro to shorten the code and simplify.

Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
---
 drivers/pinctrl/bcm/pinctrl-bcm6358.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6358.c b/drivers/pinctrl/bcm/pinctrl-bcm6358.c
index 891de49d76e7..4c8cd65fc31e 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6358.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6358.c
@@ -343,10 +343,8 @@ static int bcm6358_pinctrl_probe(struct platform_device *pdev)
 	pc = platform_get_drvdata(pdev);
 
 	priv->overlays = devm_regmap_field_alloc(dev, pc->regs, overlays);
-	if (IS_ERR(priv->overlays))
-		return PTR_ERR(priv->overlays);
 
-	return 0;
+	return PTR_ERR_OR_ZERO(priv->overlays);
 }
 
 static const struct of_device_id bcm6358_pinctrl_match[] = {
-- 
2.34.1

Re: [PATCH] pinctrl: bcm: use PTR_ERR_OR_ZERO() to simplify code

Posted by Linus Walleij 1 month, 2 weeks ago

On Tue, Aug 12, 2025 at 10:12 AM Xichao Zhao <zhao.xichao@vivo.com> wrote:

> Use the standard error pointer macro to shorten the code and simplify.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>

Patch applied!

Yours,
Linus Walleij