[PATCH] pinctrl: equilibrium: Remove redundant semicolons

Liao Yuanhong posted 1 patch 1 month, 3 weeks ago
drivers/pinctrl/pinctrl-equilibrium.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] pinctrl: equilibrium: Remove redundant semicolons
Posted by Liao Yuanhong 1 month, 3 weeks ago
Remove unnecessary semicolons.

Fixes: 1948d5c51dba4 ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
 drivers/pinctrl/pinctrl-equilibrium.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-equilibrium.c b/drivers/pinctrl/pinctrl-equilibrium.c
index fce804d42e7d..f449576488d9 100644
--- a/drivers/pinctrl/pinctrl-equilibrium.c
+++ b/drivers/pinctrl/pinctrl-equilibrium.c
@@ -439,7 +439,6 @@ static int eqbr_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin,
 	}
 	raw_spin_unlock_irqrestore(&pctl->lock, flags);
 	*config = pinconf_to_config_packed(param, val);
-;
 	return 0;
 }
 
-- 
2.34.1
Re: [PATCH] pinctrl: equilibrium: Remove redundant semicolons
Posted by Linus Walleij 1 month, 2 weeks ago
On Tue, Aug 12, 2025 at 9:54 AM Liao Yuanhong <liaoyuanhong@vivo.com> wrote:

> Remove unnecessary semicolons.
>
> Fixes: 1948d5c51dba4 ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>

Patch applied as nonurgent fix, modified to keep as blank
line as suggested by Andy while applying.

Yours,
Linus Walleij
Re: [PATCH] pinctrl: equilibrium: Remove redundant semicolons
Posted by Andy Shevchenko 1 month, 3 weeks ago
On Tue, Aug 12, 2025 at 03:54:44PM +0800, Liao Yuanhong wrote:
> Remove unnecessary semicolons.

While this is a good one
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

...

>  	raw_spin_unlock_irqrestore(&pctl->lock, flags);
>  	*config = pinconf_to_config_packed(param, val);
> -;
>  	return 0;


...I would still keep a blank line before return. But I leave it to Linus to
decide or even amend when applying.

-- 
With Best Regards,
Andy Shevchenko