Remove unnecessary semicolons.

Fixes: 86814d8ffd55f ("vsock/test: verify socket options after setting them")
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
 tools/testing/vsock/util.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
index 7b861a8e997a..d843643ced6b 100644
--- a/tools/testing/vsock/util.c
+++ b/tools/testing/vsock/util.c
@@ -756,7 +756,6 @@ void setsockopt_ull_check(int fd, int level, int optname,
 fail:
 	fprintf(stderr, "%s  val %llu\n", errmsg, val);
 	exit(EXIT_FAILURE);
-;
 }
 
 /* Set "int" socket option and check that it's indeed set */
-- 
2.34.1

On Tue, Aug 12, 2025 at 12:01:15PM +0800, Liao Yuanhong wrote:
> Remove unnecessary semicolons.
> 
> Fixes: 86814d8ffd55f ("vsock/test: verify socket options after setting them")
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
>  tools/testing/vsock/util.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
> index 7b861a8e997a..d843643ced6b 100644
> --- a/tools/testing/vsock/util.c
> +++ b/tools/testing/vsock/util.c
> @@ -756,7 +756,6 @@ void setsockopt_ull_check(int fd, int level, int optname,
>  fail:
>  	fprintf(stderr, "%s  val %llu\n", errmsg, val);
>  	exit(EXIT_FAILURE);
> -;
>  }

This isn't a fixes since it doesn't fix a bug; it's cleanup so I'd probably
target net-next and drop the fixes tag.

On 8/13/2025 1:45 AM, Joe Damato wrote:

> [You don't often get email from joe@dama.to. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On Tue, Aug 12, 2025 at 12:01:15PM +0800, Liao Yuanhong wrote:
>> Remove unnecessary semicolons.
>>
>> Fixes: 86814d8ffd55f ("vsock/test: verify socket options after setting them")
>> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
>> ---
>>   tools/testing/vsock/util.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
>> index 7b861a8e997a..d843643ced6b 100644
>> --- a/tools/testing/vsock/util.c
>> +++ b/tools/testing/vsock/util.c
>> @@ -756,7 +756,6 @@ void setsockopt_ull_check(int fd, int level, int optname,
>>   fail:
>>        fprintf(stderr, "%s  val %llu\n", errmsg, val);
>>        exit(EXIT_FAILURE);
>> -;
>>   }
> This isn't a fixes since it doesn't fix a bug; it's cleanup so I'd probably
> target net-next and drop the fixes tag.

Do you need me to resend the v2 version without the fixes tag?


Thanks,

Liao

On Wed, 13 Aug 2025 at 08:57, Liao Yuanhong <liaoyuanhong@vivo.com> wrote:
>
> On 8/13/2025 1:45 AM, Joe Damato wrote:
>
> > [You don't often get email from joe@dama.to. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > On Tue, Aug 12, 2025 at 12:01:15PM +0800, Liao Yuanhong wrote:
> >> Remove unnecessary semicolons.
> >>
> >> Fixes: 86814d8ffd55f ("vsock/test: verify socket options after setting them")
> >> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> >> ---
> >>   tools/testing/vsock/util.c | 1 -
> >>   1 file changed, 1 deletion(-)
> >>
> >> diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
> >> index 7b861a8e997a..d843643ced6b 100644
> >> --- a/tools/testing/vsock/util.c
> >> +++ b/tools/testing/vsock/util.c
> >> @@ -756,7 +756,6 @@ void setsockopt_ull_check(int fd, int level, int optname,
> >>   fail:
> >>        fprintf(stderr, "%s  val %llu\n", errmsg, val);
> >>        exit(EXIT_FAILURE);
> >> -;
> >>   }
> > This isn't a fixes since it doesn't fix a bug; it's cleanup so I'd probably
> > target net-next and drop the fixes tag.
>
> Do you need me to resend the v2 version without the fixes tag?

Yes, please.

Also target net-next:
https://docs.kernel.org/process/maintainer-netdev.html#indicating-target-tree

Thanks,
Stefano

>
>
> Thanks,
>
> Liao
>