[v1] rust: auxiliary: Use `c_` types from prelude instead of

[PATCH] rust: auxiliary: Use `c_` types from prelude instead of

Posted by herculoxz 1 month, 3 weeks ago

From: Abhinav Ananthu <abhinav.ogl@gmail.com>

 Update auxiliary FFI callback signatures to reference the `c_` types
 provided by the kernel prelude, rather than accessing them via
 `kernel::ffi::`.

Signed-off-by: Abhinav Ananthu <abhinav.ogl@gmail.com>
---
 rust/kernel/auxiliary.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs
index d2cfe1eeefb6..030e31333689 100644
--- a/rust/kernel/auxiliary.rs
+++ b/rust/kernel/auxiliary.rs
@@ -56,7 +56,7 @@ impl<T: Driver + 'static> Adapter<T> {
     extern "C" fn probe_callback(
         adev: *mut bindings::auxiliary_device,
         id: *const bindings::auxiliary_device_id,
-    ) -> kernel::ffi::c_int {
+    ) -> c_int {
         // SAFETY: The auxiliary bus only ever calls the probe callback with a valid pointer to a
         // `struct auxiliary_device`.
         //
-- 
2.34.1

Re: [PATCH] rust: auxiliary: Use `c_` types from prelude instead of

Posted by Greg KH 1 month, 3 weeks ago

On Tue, Aug 12, 2025 at 09:24:21AM +0530, herculoxz wrote:
> From: Abhinav Ananthu <abhinav.ogl@gmail.com>
> 
>  Update auxiliary FFI callback signatures to reference the `c_` types
>  provided by the kernel prelude, rather than accessing them via
>  `kernel::ffi::`.

Why is this indented?

Also, note that your "From:" line in your email client doesn't reflect
your name here.  That might be fine, but it's a bit odd and triggers my
checks.

thanks,

greg k-h