.../bindings/pinctrl/nvidia,tegra186-pinmux.yaml | 285 +++ arch/arm64/boot/dts/nvidia/tegra186.dtsi | 12 + drivers/pinctrl/tegra/Kconfig | 4 + drivers/pinctrl/tegra/Makefile | 1 + drivers/pinctrl/tegra/pinctrl-tegra186.c | 1979 ++++++++++++++++++++ drivers/soc/tegra/Kconfig | 1 + 6 files changed, 2282 insertions(+)
This series adds support for Tegra186 pin control, based on a downstream driver, updated to match the existing Tegra194 driver. Signed-off-by: Aaron Kling <webgeek1234@gmail.com> --- Changes in v3: - Fixed some spacing and formating issues in patch 2 - Link to v2: https://lore.kernel.org/r/20250608-tegra186-pinctrl-v2-0-502d41f3eedd@gmail.com Changes in v2: - Don't allow underscores in node names in patch 1 - Rebase on v6.16-rc1 - Patch 2 was picked up and thus not in the rebase - Link to v1: https://lore.kernel.org/r/20250429-tegra186-pinctrl-v1-0-722c7c42394e@gmail.com --- Aaron Kling (3): dt-bindings: pinctrl: Document Tegra186 pin controllers pinctrl: tegra: Add Tegra186 pinmux driver arm64: tegra: Add Tegra186 pin controllers .../bindings/pinctrl/nvidia,tegra186-pinmux.yaml | 285 +++ arch/arm64/boot/dts/nvidia/tegra186.dtsi | 12 + drivers/pinctrl/tegra/Kconfig | 4 + drivers/pinctrl/tegra/Makefile | 1 + drivers/pinctrl/tegra/pinctrl-tegra186.c | 1979 ++++++++++++++++++++ drivers/soc/tegra/Kconfig | 1 + 6 files changed, 2282 insertions(+) --- base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 change-id: 20250308-tegra186-pinctrl-651ffbbbe816 Best regards, -- Aaron Kling <webgeek1234@gmail.com>
On Tue, Aug 12, 2025 at 11:24 PM Aaron Kling via B4 Relay <devnull+webgeek1234.gmail.com@kernel.org> wrote: > This series adds support for Tegra186 pin control, based on a downstream > driver, updated to match the existing Tegra194 driver. > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com> (...) > Aaron Kling (3): > dt-bindings: pinctrl: Document Tegra186 pin controllers > pinctrl: tegra: Add Tegra186 pinmux driver These two applied to the pin control git tree. > arm64: tegra: Add Tegra186 pin controllers Please funnel this one through the Tegra SoC tree! (I don't know who managed that, probably Thierry.) Yours, Linus Walleij
On Tue, Aug 19, 2025 at 6:30 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Tue, Aug 12, 2025 at 11:24 PM Aaron Kling via B4 Relay > <devnull+webgeek1234.gmail.com@kernel.org> wrote: > > > This series adds support for Tegra186 pin control, based on a downstream > > driver, updated to match the existing Tegra194 driver. > > > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com> > (...) > > Aaron Kling (3): > > dt-bindings: pinctrl: Document Tegra186 pin controllers > > pinctrl: tegra: Add Tegra186 pinmux driver > > These two applied to the pin control git tree. On patch 3, Mikko noted that I accidentally amended the formatting changes intended for patch 2 into patch 3. Linus, since you've already picked this up to your tree, is it too late to fix this properly in a new revision? It doesn't appear to have made it to the main tree yet. Or do I need to send in a fixup? Aaron
On Wed, Sep 3, 2025 at 6:54 AM Aaron Kling <webgeek1234@gmail.com> wrote: > On Tue, Aug 19, 2025 at 6:30 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > On Tue, Aug 12, 2025 at 11:24 PM Aaron Kling via B4 Relay > > <devnull+webgeek1234.gmail.com@kernel.org> wrote: > > > > > This series adds support for Tegra186 pin control, based on a downstream > > > driver, updated to match the existing Tegra194 driver. > > > > > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com> > > (...) > > > Aaron Kling (3): > > > dt-bindings: pinctrl: Document Tegra186 pin controllers > > > pinctrl: tegra: Add Tegra186 pinmux driver > > > > These two applied to the pin control git tree. > > On patch 3, Mikko noted that I accidentally amended the formatting > changes intended for patch 2 into patch 3. Linus, since you've already > picked this up to your tree, is it too late to fix this properly in a > new revision? It doesn't appear to have made it to the main tree yet. > Or do I need to send in a fixup? It's one of the first drivers I merged with plenty of other stuff on top so I can't amend it, just send a fixup based on my "devel" branch (or linux-next, it should work too). Yours, Linus Walleij
On Wed, Sep 3, 2025 at 1:55 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Sep 3, 2025 at 6:54 AM Aaron Kling <webgeek1234@gmail.com> wrote: > > On Tue, Aug 19, 2025 at 6:30 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > > > On Tue, Aug 12, 2025 at 11:24 PM Aaron Kling via B4 Relay > > > <devnull+webgeek1234.gmail.com@kernel.org> wrote: > > > > > > > This series adds support for Tegra186 pin control, based on a downstream > > > > driver, updated to match the existing Tegra194 driver. > > > > > > > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com> > > > (...) > > > > Aaron Kling (3): > > > > dt-bindings: pinctrl: Document Tegra186 pin controllers > > > > pinctrl: tegra: Add Tegra186 pinmux driver > > > > > > These two applied to the pin control git tree. > > > > On patch 3, Mikko noted that I accidentally amended the formatting > > changes intended for patch 2 into patch 3. Linus, since you've already > > picked this up to your tree, is it too late to fix this properly in a > > new revision? It doesn't appear to have made it to the main tree yet. > > Or do I need to send in a fixup? > > It's one of the first drivers I merged with plenty of other stuff on top > so I can't amend it, just send a fixup based on my "devel" branch > (or linux-next, it should work too). I am highly confused now. When I went to make the fixup series, the fixup didn't apply. Looking at next-20250903 [0], pinctrl-tegra186.c looks like I wanted it to, the base commit has all the format fixes. Which doesn't match the commit on this series. Which leads me to a couple questions: 1) Does anyone know what happened? I'm not particularly a fan of not knowing why something happened, even if it's beneficial at the time. 2) What should I do with the dt commit now? Ask the Tegra subsystem maintainer to do a manual fixup when pulling? Even without a manual fixup, the bad part of the commit would fall out when getting applied on top of next. Aaron [0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/pinctrl/tegra/pinctrl-tegra186.c?h=next-20250903
On Wed, Sep 03, 2025 at 12:58:06PM -0500, Aaron Kling wrote: > On Wed, Sep 3, 2025 at 1:55 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > On Wed, Sep 3, 2025 at 6:54 AM Aaron Kling <webgeek1234@gmail.com> wrote: > > > On Tue, Aug 19, 2025 at 6:30 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > > > > > On Tue, Aug 12, 2025 at 11:24 PM Aaron Kling via B4 Relay > > > > <devnull+webgeek1234.gmail.com@kernel.org> wrote: > > > > > > > > > This series adds support for Tegra186 pin control, based on a downstream > > > > > driver, updated to match the existing Tegra194 driver. > > > > > > > > > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com> > > > > (...) > > > > > Aaron Kling (3): > > > > > dt-bindings: pinctrl: Document Tegra186 pin controllers > > > > > pinctrl: tegra: Add Tegra186 pinmux driver > > > > > > > > These two applied to the pin control git tree. > > > > > > On patch 3, Mikko noted that I accidentally amended the formatting > > > changes intended for patch 2 into patch 3. Linus, since you've already > > > picked this up to your tree, is it too late to fix this properly in a > > > new revision? It doesn't appear to have made it to the main tree yet. > > > Or do I need to send in a fixup? > > > > It's one of the first drivers I merged with plenty of other stuff on top > > so I can't amend it, just send a fixup based on my "devel" branch > > (or linux-next, it should work too). > > I am highly confused now. When I went to make the fixup series, the > fixup didn't apply. Looking at next-20250903 [0], pinctrl-tegra186.c > looks like I wanted it to, the base commit has all the format fixes. > Which doesn't match the commit on this series. Which leads me to a > couple questions: > > 1) Does anyone know what happened? I'm not particularly a fan of not > knowing why something happened, even if it's beneficial at the time. Maybe auto-formatting or something else that Linus did? > 2) What should I do with the dt commit now? Ask the Tegra subsystem > maintainer to do a manual fixup when pulling? Even without a manual > fixup, the bad part of the commit would fall out when getting applied > on top of next. I can drop the extra hunks when applying, no need to do anything. Thierry
© 2016 - 2025 Red Hat, Inc.