[PATCH 0/6] kbuild: uapi: various fixes

Thomas Weißschuh posted 6 patches 1 month, 3 weeks ago
There is a newer version of this series
usr/include/Makefile         | 8 ++++----
usr/include/headers_check.pl | 9 ++++-----
2 files changed, 8 insertions(+), 9 deletions(-)
[PATCH 0/6] kbuild: uapi: various fixes
Posted by Thomas Weißschuh 1 month, 3 weeks ago
Various fixes and promotion of warnings to real errors.

I didn't add Fixes: tags as digging up the original changes would be
cumbersome as the code moved a lot over the years.
Backporting this doesn't make sense anyways.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
Thomas Weißschuh (6):
      kbuild: uapi: rerun header tests when headers_check.pl changes
      kbuild: uapi: only update hdrtest output on success
      kbuild: uapi: fail header test on compiler warnings
      kbuild: uapi: upgrade warning on asm/types.h inclusion to error
      kbuild: uapi: upgrade check_sizetypes() warning to error
      kbuild: uapi: upgrade check_declarations() warning to error

 usr/include/Makefile         | 8 ++++----
 usr/include/headers_check.pl | 9 ++++-----
 2 files changed, 8 insertions(+), 9 deletions(-)
---
base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
change-id: 20250811-kbuild-hdrtest-fixes-1bf147b3ddd3

Best regards,
-- 
Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Re: [PATCH 0/6] kbuild: uapi: various fixes
Posted by Nathan Chancellor 1 month, 3 weeks ago
Hi Thomas,

On Tue, Aug 12, 2025 at 07:33:03AM +0200, Thomas Weißschuh wrote:
> Various fixes and promotion of warnings to real errors.
> 
> I didn't add Fixes: tags as digging up the original changes would be
> cumbersome as the code moved a lot over the years.
> Backporting this doesn't make sense anyways.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> Thomas Weißschuh (6):
>       kbuild: uapi: rerun header tests when headers_check.pl changes
>       kbuild: uapi: only update hdrtest output on success
>       kbuild: uapi: fail header test on compiler warnings
>       kbuild: uapi: upgrade warning on asm/types.h inclusion to error
>       kbuild: uapi: upgrade check_sizetypes() warning to error
>       kbuild: uapi: upgrade check_declarations() warning to error

This series seems reasonable. I did a build of usr/ on arm64 and x86_64
allmodconfig, which showed no issues. I will give Nicolas a few days to
comment, after which I will apply these to the Kbuild tree so we can
start soak testing in -next.

Cheers,
Nathan
Re: [PATCH 0/6] kbuild: uapi: various fixes
Posted by Nicolas Schier 1 month, 3 weeks ago
On Tue, Aug 12, 2025 at 04:44:58PM -0700, Nathan Chancellor wrote:
> Hi Thomas,
> 
> On Tue, Aug 12, 2025 at 07:33:03AM +0200, Thomas Weißschuh wrote:
> > Various fixes and promotion of warnings to real errors.
> > 
> > I didn't add Fixes: tags as digging up the original changes would be
> > cumbersome as the code moved a lot over the years.
> > Backporting this doesn't make sense anyways.
> > 
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> > ---
> > Thomas Weißschuh (6):
> >       kbuild: uapi: rerun header tests when headers_check.pl changes
> >       kbuild: uapi: only update hdrtest output on success
> >       kbuild: uapi: fail header test on compiler warnings
> >       kbuild: uapi: upgrade warning on asm/types.h inclusion to error
> >       kbuild: uapi: upgrade check_sizetypes() warning to error
> >       kbuild: uapi: upgrade check_declarations() warning to error
> 
> This series seems reasonable. I did a build of usr/ on arm64 and x86_64
> allmodconfig, which showed no issues. I will give Nicolas a few days to
> comment, after which I will apply these to the Kbuild tree so we can
> start soak testing in -next.

thanks.  With the exception of the already canceled patch 2, this looks
good to me.

Reviewed-by: Nicolas Schier <nsc@kernel.org>

Kind regards,
Nicolas