cxl/region: use str_enabled_disabled() instead of tenary operator

[PATCH] cxl/region: use str_enabled_disabled() instead of tenary operator

Posted by Nai-Chen Cheng 1 month, 3 weeks ago

Replace tenary operator with str_enabled_disabled() helper to enhance
code readability and consistency.

Signed-off-by: Nai-Chen Cheng <bleach1827@gmail.com>
---
 drivers/cxl/core/region.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index 71cc42d05248..83d58787b5af 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -10,6 +10,7 @@
 #include <linux/sort.h>
 #include <linux/idr.h>
 #include <linux/memory-tiers.h>
+#include <linux/string_choices.h>
 #include <cxlmem.h>
 #include <cxl.h>
 #include "core.h"
@@ -1468,9 +1469,7 @@ static int cxl_port_setup_targets(struct cxl_port *port,
 				dev_name(port->uport_dev), dev_name(&port->dev),
 				__func__, cxld->interleave_ways,
 				cxld->interleave_granularity,
-				(cxld->flags & CXL_DECODER_F_ENABLE) ?
-					"enabled" :
-					"disabled",
+				str_enabled_disabled(cxld->flags & CXL_DECODER_F_ENABLE),
 				cxld->hpa_range.start, cxld->hpa_range.end);
 			return -ENXIO;
 		}

---
base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
change-id: 20250812-cxl-region-string-choices-f5aa9832346e

Best regards,
-- 
Nai-Chen Cheng <bleach1827@gmail.com>

Re: [PATCH] cxl/region: use str_enabled_disabled() instead of tenary operator

Posted by Dave Jiang 1 month, 3 weeks ago


On 8/11/25 9:49 AM, Nai-Chen Cheng wrote:
> Replace tenary operator with str_enabled_disabled() helper to enhance
> code readability and consistency.
> 
> Signed-off-by: Nai-Chen Cheng <bleach1827@gmail.com>

Applied to cxl/next. Spelling mistakes noted by Alison fixed.
733c4e9bcec9

> ---
>  drivers/cxl/core/region.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index 71cc42d05248..83d58787b5af 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -10,6 +10,7 @@
>  #include <linux/sort.h>
>  #include <linux/idr.h>
>  #include <linux/memory-tiers.h>
> +#include <linux/string_choices.h>
>  #include <cxlmem.h>
>  #include <cxl.h>
>  #include "core.h"
> @@ -1468,9 +1469,7 @@ static int cxl_port_setup_targets(struct cxl_port *port,
>  				dev_name(port->uport_dev), dev_name(&port->dev),
>  				__func__, cxld->interleave_ways,
>  				cxld->interleave_granularity,
> -				(cxld->flags & CXL_DECODER_F_ENABLE) ?
> -					"enabled" :
> -					"disabled",
> +				str_enabled_disabled(cxld->flags & CXL_DECODER_F_ENABLE),
>  				cxld->hpa_range.start, cxld->hpa_range.end);
>  			return -ENXIO;
>  		}
> 
> ---
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> change-id: 20250812-cxl-region-string-choices-f5aa9832346e
> 
> Best regards,

Re: [PATCH] cxl/region: use str_enabled_disabled() instead of tenary operator

Posted by Alison Schofield 1 month, 3 weeks ago

On Tue, Aug 12, 2025 at 12:49:46AM +0800, Nai-Chen Cheng wrote:
> Replace tenary operator with str_enabled_disabled() helper to enhance
> code readability and consistency.
> 
> Signed-off-by: Nai-Chen Cheng <bleach1827@gmail.com>
> ---

Thanks for the patch!

DaveJ - Please fix-up the spelling when you apply s/tenary/ternary in
both commit message and log. With that, add:
Reviewed-by: Alison Schofield <alison.schofield@intel.com>

Nai-Chen Cheng - If you're able to pick up a related cleanup, I believe
drivers/cxl/core/hdm.c has a place where str_plural() could be used.

-- Alison


>  drivers/cxl/core/region.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index 71cc42d05248..83d58787b5af 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -10,6 +10,7 @@
>  #include <linux/sort.h>
>  #include <linux/idr.h>
>  #include <linux/memory-tiers.h>
> +#include <linux/string_choices.h>
>  #include <cxlmem.h>
>  #include <cxl.h>
>  #include "core.h"
> @@ -1468,9 +1469,7 @@ static int cxl_port_setup_targets(struct cxl_port *port,
>  				dev_name(port->uport_dev), dev_name(&port->dev),
>  				__func__, cxld->interleave_ways,
>  				cxld->interleave_granularity,
> -				(cxld->flags & CXL_DECODER_F_ENABLE) ?
> -					"enabled" :
> -					"disabled",
> +				str_enabled_disabled(cxld->flags & CXL_DECODER_F_ENABLE),
>  				cxld->hpa_range.start, cxld->hpa_range.end);
>  			return -ENXIO;
>  		}
> 
> ---
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> change-id: 20250812-cxl-region-string-choices-f5aa9832346e
> 
> Best regards,
> -- 
> Nai-Chen Cheng <bleach1827@gmail.com>
>

Re: [PATCH] cxl/region: use str_enabled_disabled() instead of tenary operator

Posted by Alison Schofield 1 month, 3 weeks ago

On Mon, Aug 11, 2025 at 05:08:13PM -0700, Alison Schofield wrote:
> On Tue, Aug 12, 2025 at 12:49:46AM +0800, Nai-Chen Cheng wrote:
> > Replace tenary operator with str_enabled_disabled() helper to enhance
> > code readability and consistency.
> > 
> > Signed-off-by: Nai-Chen Cheng <bleach1827@gmail.com>
> > ---
> 
> Thanks for the patch!
> 
> DaveJ - Please fix-up the spelling when you apply s/tenary/ternary in
> both commit message and log. With that, add:
> Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> 
> Nai-Chen Cheng - If you're able to pick up a related cleanup, I believe
> drivers/cxl/core/hdm.c has a place where str_plural() could be used.
Oops...I guess I should read these in FIFO order. I see str_plural()
already on the list :)

> 
> -- Alison
> 
> 
> >  drivers/cxl/core/region.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> > index 71cc42d05248..83d58787b5af 100644
> > --- a/drivers/cxl/core/region.c
> > +++ b/drivers/cxl/core/region.c
> > @@ -10,6 +10,7 @@
> >  #include <linux/sort.h>
> >  #include <linux/idr.h>
> >  #include <linux/memory-tiers.h>
> > +#include <linux/string_choices.h>
> >  #include <cxlmem.h>
> >  #include <cxl.h>
> >  #include "core.h"
> > @@ -1468,9 +1469,7 @@ static int cxl_port_setup_targets(struct cxl_port *port,
> >  				dev_name(port->uport_dev), dev_name(&port->dev),
> >  				__func__, cxld->interleave_ways,
> >  				cxld->interleave_granularity,
> > -				(cxld->flags & CXL_DECODER_F_ENABLE) ?
> > -					"enabled" :
> > -					"disabled",
> > +				str_enabled_disabled(cxld->flags & CXL_DECODER_F_ENABLE),
> >  				cxld->hpa_range.start, cxld->hpa_range.end);
> >  			return -ENXIO;
> >  		}
> > 
> > ---
> > base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> > change-id: 20250812-cxl-region-string-choices-f5aa9832346e
> > 
> > Best regards,
> > -- 
> > Nai-Chen Cheng <bleach1827@gmail.com>
> > 
>