Enable Multi-Circular Queue (MCQ) support for the UFS host controller
on the Qualcomm SM8650 platform by updating the device tree node. This
includes adding new register region for MCQ and specifying the MSI parent
required for MCQ operation.
Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
---
arch/arm64/boot/dts/qcom/sm8650.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
index e14d3d778b71..1885d88abc3a 100644
--- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
@@ -3982,7 +3982,10 @@ ufs_mem_phy: phy@1d80000 {
ufs_mem_hc: ufshc@1d84000 {
compatible = "qcom,sm8650-ufshc", "qcom,ufshc", "jedec,ufs-2.0";
- reg = <0 0x01d84000 0 0x3000>;
+ reg = <0 0x01d84000 0 0x3000>,
+ <0 0x1da0000 0 0x15000>;
+ reg-names = "ufs_mem",
+ "mcq";
interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH 0>;
@@ -4020,6 +4023,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
iommus = <&apps_smmu 0x60 0>;
+ msi-parent = <&gic_its 0x60>;
+
lanes-per-direction = <2>;
qcom,ice = <&ice>;
--
2.50.1On 11/08/2025 16:31, Ram Kumar Dwivedi wrote: > Enable Multi-Circular Queue (MCQ) support for the UFS host controller > on the Qualcomm SM8650 platform by updating the device tree node. This > includes adding new register region for MCQ and specifying the MSI parent > required for MCQ operation. > > Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sm8650.dtsi | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Way you organize your patchset is confusing. Why DTS is in the middle? It suggests dependency and this would be strong objection from me. Please read carefully writing bindings, submitting patches in DT and SoC maintainer profile. Best regards, Krzysztof
On 11-Aug-25 8:13 PM, Krzysztof Kozlowski wrote: > On 11/08/2025 16:31, Ram Kumar Dwivedi wrote: >> Enable Multi-Circular Queue (MCQ) support for the UFS host controller >> on the Qualcomm SM8650 platform by updating the device tree node. This >> includes adding new register region for MCQ and specifying the MSI parent >> required for MCQ operation. >> >> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sm8650.dtsi | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) > > Way you organize your patchset is confusing. Why DTS is in the middle? > It suggests dependency and this would be strong objection from me. Hi Krzysztof, My current patch submission order is as follows: 1.DT binding 2.Device tree 3.Driver changes Please let me know if you'd prefer to rearrange the order and place the driver patch in the middle. Regards, Ram > > Please read carefully writing bindings, submitting patches in DT and SoC > maintainer profile. > > Best regards, > Krzysztof
On Mon, Aug 11, 2025 at 10:24:29PM +0530, Ram Kumar Dwivedi wrote: > > > On 11-Aug-25 8:13 PM, Krzysztof Kozlowski wrote: > > On 11/08/2025 16:31, Ram Kumar Dwivedi wrote: > >> Enable Multi-Circular Queue (MCQ) support for the UFS host controller > >> on the Qualcomm SM8650 platform by updating the device tree node. This > >> includes adding new register region for MCQ and specifying the MSI parent > >> required for MCQ operation. > >> > >> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com> > >> --- > >> arch/arm64/boot/dts/qcom/sm8650.dtsi | 7 ++++++- > >> 1 file changed, 6 insertions(+), 1 deletion(-) > > > > Way you organize your patchset is confusing. Why DTS is in the middle? > > It suggests dependency and this would be strong objection from me. > > Hi Krzysztof, > > My current patch submission order is as follows: > > 1.DT binding > 2.Device tree > 3.Driver changes > > Please let me know if you'd prefer to rearrange the order and place the driver patch in the middle. THe recommended way is opposite: - DT bindings - Driver changes - DT changes This lets maintainers to pick up their parts with less troubles. > > > Regards, > Ram > > > > Please read carefully writing bindings, submitting patches in DT and SoC > > maintainer profile. > > > > Best regards, > > Krzysztof > -- With best wishes Dmitry
On 12-Aug-25 4:25 PM, Dmitry Baryshkov wrote: > On Mon, Aug 11, 2025 at 10:24:29PM +0530, Ram Kumar Dwivedi wrote: >> >> >> On 11-Aug-25 8:13 PM, Krzysztof Kozlowski wrote: >>> On 11/08/2025 16:31, Ram Kumar Dwivedi wrote: >>>> Enable Multi-Circular Queue (MCQ) support for the UFS host controller >>>> on the Qualcomm SM8650 platform by updating the device tree node. This >>>> includes adding new register region for MCQ and specifying the MSI parent >>>> required for MCQ operation. >>>> >>>> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com> >>>> --- >>>> arch/arm64/boot/dts/qcom/sm8650.dtsi | 7 ++++++- >>>> 1 file changed, 6 insertions(+), 1 deletion(-) >>> >>> Way you organize your patchset is confusing. Why DTS is in the middle? >>> It suggests dependency and this would be strong objection from me. >> >> Hi Krzysztof, >> >> My current patch submission order is as follows: >> >> 1.DT binding >> 2.Device tree >> 3.Driver changes >> >> Please let me know if you'd prefer to rearrange the order and place the driver patch in the middle. > > THe recommended way is opposite: > > - DT bindings > - Driver changes > - DT changes > > This lets maintainers to pick up their parts with less troubles. Hi Dmitry and Krzysztof, Thanks for the suggestion. I'll update the next patchset order to follow the recommended structure: 1. DT bindings 2. Driver changes 3. DT changes Appreciate the guidance. Thanks, Ram. > >> >> >> Regards, >> Ram >>> >>> Please read carefully writing bindings, submitting patches in DT and SoC >>> maintainer profile. >>> >>> Best regards, >>> Krzysztof >> >
On 11/08/2025 18:54, Ram Kumar Dwivedi wrote: > > > On 11-Aug-25 8:13 PM, Krzysztof Kozlowski wrote: >> On 11/08/2025 16:31, Ram Kumar Dwivedi wrote: >>> Enable Multi-Circular Queue (MCQ) support for the UFS host controller >>> on the Qualcomm SM8650 platform by updating the device tree node. This >>> includes adding new register region for MCQ and specifying the MSI parent >>> required for MCQ operation. >>> >>> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/sm8650.dtsi | 7 ++++++- >>> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> Way you organize your patchset is confusing. Why DTS is in the middle? >> It suggests dependency and this would be strong objection from me. > > Hi Krzysztof, > > My current patch submission order is as follows: > > 1.DT binding > 2.Device tree > 3.Driver changes Why are you repeating the obvious? That order is INCORRECT and that is why I commented. > > Please let me know if you'd prefer to rearrange the order and place the driver patch in the middle. I need to you read the documents I mentioned. It is your task to read the docs, not asking me to quote them again because you do not bother with that. Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.