Document Multi-Circular Queue (MCQ) register space for
Qualcomm UFS controllers.
Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
---
.../devicetree/bindings/ufs/qcom,ufs.yaml | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index 6c6043d9809e..daf681b0e23b 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -89,9 +89,13 @@ properties:
maxItems: 2
reg-names:
- items:
- - const: std
- - const: ice
+ oneOf:
+ - items:
+ - const: std
+ - const: ice
+ - items:
+ - const: ufs_mem
+ - const: mcq
required-opps:
maxItems: 1
@@ -177,9 +181,9 @@ allOf:
- const: rx_lane1_sync_clk
reg:
minItems: 1
- maxItems: 1
+ maxItems: 2
reg-names:
- maxItems: 1
+ maxItems: 2
- if:
properties:
@@ -280,7 +284,7 @@ allOf:
then:
properties:
reg:
- maxItems: 1
+ maxItems: 2
clocks:
minItems: 7
maxItems: 8
--
2.50.1On Mon, Aug 11, 2025 at 08:01:36PM +0530, Ram Kumar Dwivedi wrote: > Document Multi-Circular Queue (MCQ) register space for > Qualcomm UFS controllers. > > Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com> > --- > .../devicetree/bindings/ufs/qcom,ufs.yaml | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index 6c6043d9809e..daf681b0e23b 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -89,9 +89,13 @@ properties: > maxItems: 2 > > reg-names: > - items: > - - const: std > - - const: ice > + oneOf: > + - items: > + - const: std > + - const: ice > + - items: > + - const: ufs_mem > + - const: mcq So you can either "std" and "ice", or "ufs_mem" and "mcq". Does this imply that "std" changes name to "ufs_mem"? Why? Is MCQ incompatible with ICE? Please use the commit message to document why this is. Regards, Bjorn > > required-opps: > maxItems: 1 > @@ -177,9 +181,9 @@ allOf: > - const: rx_lane1_sync_clk > reg: > minItems: 1 > - maxItems: 1 > + maxItems: 2 > reg-names: > - maxItems: 1 > + maxItems: 2 > > - if: > properties: > @@ -280,7 +284,7 @@ allOf: > then: > properties: > reg: > - maxItems: 1 > + maxItems: 2 > clocks: > minItems: 7 > maxItems: 8 > -- > 2.50.1 >
On 11/08/2025 17:02, Bjorn Andersson wrote: > On Mon, Aug 11, 2025 at 08:01:36PM +0530, Ram Kumar Dwivedi wrote: >> Document Multi-Circular Queue (MCQ) register space for >> Qualcomm UFS controllers. >> >> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com> >> --- >> .../devicetree/bindings/ufs/qcom,ufs.yaml | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> index 6c6043d9809e..daf681b0e23b 100644 >> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> @@ -89,9 +89,13 @@ properties: >> maxItems: 2 >> >> reg-names: >> - items: >> - - const: std >> - - const: ice >> + oneOf: >> + - items: >> + - const: std >> + - const: ice >> + - items: >> + - const: ufs_mem >> + - const: mcq > > So you can either "std" and "ice", or "ufs_mem" and "mcq". > > Does this imply that "std" changes name to "ufs_mem"? Why? > Is MCQ incompatible with ICE? I commented on v1 what has to be fixed. I also said I will provide the actual fix and then this is sent ignoring my comments and ignoring my fix. So no, this does not get fixed. NAK. Best regards, Krzysztof
On 11-Aug-25 8:32 PM, Bjorn Andersson wrote: > On Mon, Aug 11, 2025 at 08:01:36PM +0530, Ram Kumar Dwivedi wrote: >> Document Multi-Circular Queue (MCQ) register space for >> Qualcomm UFS controllers. >> >> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com> >> --- >> .../devicetree/bindings/ufs/qcom,ufs.yaml | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> index 6c6043d9809e..daf681b0e23b 100644 >> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> @@ -89,9 +89,13 @@ properties: >> maxItems: 2 >> >> reg-names: >> - items: >> - - const: std >> - - const: ice >> + oneOf: >> + - items: >> + - const: std >> + - const: ice >> + - items: >> + - const: ufs_mem >> + - const: mcq > > So you can either "std" and "ice", or "ufs_mem" and "mcq". > > Does this imply that "std" changes name to "ufs_mem"? Why? Hi Bjorn, The "std" is renamed to "ufs_mem" to more accurately represent the memory-mapped region associated with UFS controller. > Is MCQ incompatible with ICE? Yes, MCQ is compatible with ICE. Actually there are 3 possible cases: - Case 1: Older Targets (e.g., SM8150) The UFS controller node includes both "std" and "ice" in the reg-name. - Case 2: Recent Non-MCQ Targets(SM8550) ICE is defined in a separate node, outside the UFS node, and the `reg-name` is not specified. - Case 3: MCQ-Enabled Targets(SM8650,SM8750 - Part of Current Patch) The reg-name includes both "ufs_mem" and "mcq" regions. In summary, across all three scenarios, the configuration may include: - "std" and "ice" together, - "ufs_mem" and "mcq" together, or - no reg-name defined at all. > > > Please use the commit message to document why this is. I will mention this in commit message of next patch set. Thanks, Ram. > > Regards, > Bjorn > >> >> required-opps: >> maxItems: 1 >> @@ -177,9 +181,9 @@ allOf: >> - const: rx_lane1_sync_clk >> reg: >> minItems: 1 >> - maxItems: 1 >> + maxItems: 2 >> reg-names: >> - maxItems: 1 >> + maxItems: 2 >> >> - if: >> properties: >> @@ -280,7 +284,7 @@ allOf: >> then: >> properties: >> reg: >> - maxItems: 1 >> + maxItems: 2 >> clocks: >> minItems: 7 >> maxItems: 8 >> -- >> 2.50.1 >>
On 11/08/2025 16:31, Ram Kumar Dwivedi wrote: > Document Multi-Circular Queue (MCQ) register space for > Qualcomm UFS controllers. > > Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com> > --- > .../devicetree/bindings/ufs/qcom,ufs.yaml | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index 6c6043d9809e..daf681b0e23b 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -89,9 +89,13 @@ properties: > maxItems: 2 > > reg-names: > - items: > - - const: std > - - const: ice > + oneOf: > + - items: > + - const: std > + - const: ice > + - items: > + - const: ufs_mem > + - const: mcq No. Why are you sending this? You have been Cc-ed here: https://lore.kernel.org/all/20250731-dt-bindings-ufs-qcom-v2-3-53bb634bf95a@linaro.org/ Above is neither correct nor aligned with what I told you. Best regards, Krzysztof
On 11-Aug-25 8:12 PM, Krzysztof Kozlowski wrote: > On 11/08/2025 16:31, Ram Kumar Dwivedi wrote: >> Document Multi-Circular Queue (MCQ) register space for >> Qualcomm UFS controllers. >> >> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com> >> --- >> .../devicetree/bindings/ufs/qcom,ufs.yaml | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> index 6c6043d9809e..daf681b0e23b 100644 >> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> @@ -89,9 +89,13 @@ properties: >> maxItems: 2 >> >> reg-names: >> - items: >> - - const: std >> - - const: ice >> + oneOf: >> + - items: >> + - const: std >> + - const: ice >> + - items: >> + - const: ufs_mem >> + - const: mcq > > No. Why are you sending this? You have been Cc-ed here: > > https://lore.kernel.org/all/20250731-dt-bindings-ufs-qcom-v2-3-53bb634bf95a@linaro.org/ Hi Krzysztof, I understand I was Cc-ed on the patch thread you linked. However, if I send my patch on top of yours before it’s merged, the kernel bot might flag it due to missing base changes. Please let me know if you're okay with that — I can proceed with pushing my patch on top of yours. Thanks, Ram. > > Above is neither correct nor aligned with what I told you. > > Best regards, > Krzysztof
On 11/08/2025 18:12, Ram Kumar Dwivedi wrote: >>> + - items: >>> + - const: ufs_mem >>> + - const: mcq >> >> No. Why are you sending this? You have been Cc-ed here: >> >> https://lore.kernel.org/all/20250731-dt-bindings-ufs-qcom-v2-3-53bb634bf95a@linaro.org/ > > Hi Krzysztof, > > I understand I was Cc-ed on the patch thread you linked. However, if I send my patch on top of yours before it’s merged, the kernel bot might flag it due to missing base changes. Please let me know if you're okay with that — I can proceed with pushing my patch on top of yours. I don't understand it. We discuss this patch. What is with that conditional "if I send"? You already sent it. Please wrap your replies to match mailing list style. Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.