ext4: Using kmalloc_array() for array space allocation

[PATCH v2] ext4: Using kmalloc_array() for array space allocation

Posted by Liao Yuanhong 1 month, 3 weeks ago

Replace kmalloc(size * sizeof) with kmalloc_array() for safer memory
allocation and overflow prevention.

Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
Changes in v2:
	Corrected the wrong subject.
---
 fs/ext4/orphan.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/orphan.c b/fs/ext4/orphan.c
index 7c7f792ad6ab..524d4658fa40 100644
--- a/fs/ext4/orphan.c
+++ b/fs/ext4/orphan.c
@@ -589,8 +589,9 @@ int ext4_init_orphan_info(struct super_block *sb)
 	}
 	oi->of_blocks = inode->i_size >> sb->s_blocksize_bits;
 	oi->of_csum_seed = EXT4_I(inode)->i_csum_seed;
-	oi->of_binfo = kmalloc(oi->of_blocks*sizeof(struct ext4_orphan_block),
-			       GFP_KERNEL);
+	oi->of_binfo = kmalloc_array(oi->of_blocks,
+				     sizeof(struct ext4_orphan_block),
+				     GFP_KERNEL);
 	if (!oi->of_binfo) {
 		ret = -ENOMEM;
 		goto out_put;
-- 
2.34.1

Re: [PATCH v2] ext4: Using kmalloc_array() for array space allocation

Posted by Theodore Ts'o 1 month, 3 weeks ago

On Mon, 11 Aug 2025 20:58:16 +0800, Liao Yuanhong wrote:
> Replace kmalloc(size * sizeof) with kmalloc_array() for safer memory
> allocation and overflow prevention.
> 
> 

Applied, thanks!

[1/1] ext4: Using kmalloc_array() for array space allocation
      commit: 76dba1fe277f6befd6ef650e1946f626c547387a

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>