[PATCH] perf/core: Replace memset(0) + strscpy() with strscpy_pad()

Thorsten Blum posted 1 patch 1 month, 3 weeks ago
There is a newer version of this series
kernel/events/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
[PATCH] perf/core: Replace memset(0) + strscpy() with strscpy_pad()
Posted by Thorsten Blum 1 month, 3 weeks ago
Replace memset(0) followed by strscpy() with strscpy_pad() to improve
perf_event_comm_event(). This avoids zeroing the memory before copying
the string and ensures the destination buffer is only written to once,
simplifying the code and improving efficiency.

Use the return value of strscpy_pad() instead of calling strlen() again.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 kernel/events/core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 22fdf0c187cd..69b4a32befec 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -8961,9 +8961,8 @@ static void perf_event_comm_event(struct perf_comm_event *comm_event)
 	char comm[TASK_COMM_LEN];
 	unsigned int size;
 
-	memset(comm, 0, sizeof(comm));
-	strscpy(comm, comm_event->task->comm);
-	size = ALIGN(strlen(comm)+1, sizeof(u64));
+	size = strscpy_pad(comm, comm_event->task->comm);
+	size = ALIGN(size + 1, sizeof(u64));
 
 	comm_event->comm = comm;
 	comm_event->comm_size = size;
-- 
2.50.1