[PATCH] soc: mediatek: use bool as the function return type

Xichao Zhao posted 1 patch 1 month, 3 weeks ago
drivers/soc/mediatek/mtk-devapc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] soc: mediatek: use bool as the function return type
Posted by Xichao Zhao 1 month, 3 weeks ago
The function only returns true and false, and the places using the
function also expect a bool return type. Therefore, the function's
return type is changed from int to bool.

Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
---
 drivers/soc/mediatek/mtk-devapc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-devapc.c b/drivers/soc/mediatek/mtk-devapc.c
index f54c966138b5..33254a979156 100644
--- a/drivers/soc/mediatek/mtk-devapc.c
+++ b/drivers/soc/mediatek/mtk-devapc.c
@@ -109,7 +109,7 @@ static void mask_module_irq(struct mtk_devapc_context *ctx, bool mask)
  *                       info to VIO_DBGs registers.
  *
  */
-static int devapc_sync_vio_dbg(struct mtk_devapc_context *ctx)
+static bool devapc_sync_vio_dbg(struct mtk_devapc_context *ctx)
 {
 	void __iomem *pd_vio_shift_sta_reg;
 	void __iomem *pd_vio_shift_sel_reg;
-- 
2.34.1
Re: [PATCH] soc: mediatek: use bool as the function return type
Posted by Matthias Brugger 3 weeks, 6 days ago

On 11/08/2025 05:45, Xichao Zhao wrote:
> The function only returns true and false, and the places using the
> function also expect a bool return type. Therefore, the function's
> return type is changed from int to bool.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   drivers/soc/mediatek/mtk-devapc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-devapc.c b/drivers/soc/mediatek/mtk-devapc.c
> index f54c966138b5..33254a979156 100644
> --- a/drivers/soc/mediatek/mtk-devapc.c
> +++ b/drivers/soc/mediatek/mtk-devapc.c
> @@ -109,7 +109,7 @@ static void mask_module_irq(struct mtk_devapc_context *ctx, bool mask)
>    *                       info to VIO_DBGs registers.
>    *
>    */
> -static int devapc_sync_vio_dbg(struct mtk_devapc_context *ctx)
> +static bool devapc_sync_vio_dbg(struct mtk_devapc_context *ctx)
>   {
>   	void __iomem *pd_vio_shift_sta_reg;
>   	void __iomem *pd_vio_shift_sel_reg;