[PATCH v2 0/3] i2c: pxa: fix I2C communication on Armada 3700

Gabor Juhos posted 3 patches 1 month, 3 weeks ago
There is a newer version of this series
drivers/i2c/busses/i2c-pxa.c | 25 +++++++++++++++++++------
drivers/i2c/i2c-core-base.c  |  8 +++++++-
include/linux/i2c.h          |  4 ++++
3 files changed, 30 insertions(+), 7 deletions(-)
[PATCH v2 0/3] i2c: pxa: fix I2C communication on Armada 3700
Posted by Gabor Juhos 1 month, 3 weeks ago
There is a long standing bug which causes I2C communication not to
work on the Armada 3700 based boards. This small series restores
that functionality.

Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
Changes in v2:
  - collect offered tags
  - rebase and retest on tip of i2c/for-current
  - Link to v1: https://lore.kernel.org/r/20250511-i2c-pxa-fix-i2c-communication-v1-0-e9097d09a015@gmail.com

---
Gabor Juhos (3):
      i2c: add init_recovery() callback
      i2c: pxa: prevent calling of the generic recovery init code
      i2c: pxa: handle 'Early Bus Busy' condition on Armada 3700

 drivers/i2c/busses/i2c-pxa.c | 25 +++++++++++++++++++------
 drivers/i2c/i2c-core-base.c  |  8 +++++++-
 include/linux/i2c.h          |  4 ++++
 3 files changed, 30 insertions(+), 7 deletions(-)
---
base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
change-id: 20250510-i2c-pxa-fix-i2c-communication-3e6de1e3d0c6

Best regards,
-- 
Gabor Juhos <j4g8y7@gmail.com>
Re: [PATCH v2 0/3] i2c: pxa: fix I2C communication on Armada 3700
Posted by Andy Shevchenko 1 month, 3 weeks ago
On Mon, Aug 11, 2025 at 09:49:54PM +0200, Gabor Juhos wrote:
> There is a long standing bug which causes I2C communication not to
> work on the Armada 3700 based boards. This small series restores
> that functionality.
> 
> Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>

I didn't get this SoB chain. Who is Imre here and what is his role in all this?


-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v2 0/3] i2c: pxa: fix I2C communication on Armada 3700
Posted by Gabor Juhos 1 month, 3 weeks ago
2025. 08. 11. 22:12 keltezéssel, Andy Shevchenko írta:
> On Mon, Aug 11, 2025 at 09:49:54PM +0200, Gabor Juhos wrote:
>> There is a long standing bug which causes I2C communication not to
>> work on the Armada 3700 based boards. This small series restores
>> that functionality.
>>
>> Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
>> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> 
> I didn't get this SoB chain. Who is Imre here and what is his role in all this?
> 
> 

Imre reviewed the patches before publishing those, but we were unsure about that
the Reviewed-by tag can be used when it is offered privately before the
publicaton, so we decided to use the SoB tag instead.

It can be changed to the Rewieved-by tag if that is applicable in this case.

Regards,
Gabor
Re: [PATCH v2 0/3] i2c: pxa: fix I2C communication on Armada 3700
Posted by Andy Shevchenko 1 month, 3 weeks ago
On Wed, Aug 13, 2025 at 12:13:26PM +0200, Gabor Juhos wrote:
> 2025. 08. 11. 22:12 keltezéssel, Andy Shevchenko írta:
> > On Mon, Aug 11, 2025 at 09:49:54PM +0200, Gabor Juhos wrote:

...

> >> Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
> >> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> > 
> > I didn't get this SoB chain. Who is Imre here and what is his role in all this?
> 
> Imre reviewed the patches before publishing those, but we were unsure about that
> the Reviewed-by tag can be used when it is offered privately before the
> publicaton, so we decided to use the SoB tag instead.

It's exactly what should have been done. As a such the SoB chain is confusing
(taking into account the authorship of the patches).

> It can be changed to the Rewieved-by tag if that is applicable in this case.

Please do so.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v2 0/3] i2c: pxa: fix I2C communication on Armada 3700
Posted by Gabor Juhos 1 month, 3 weeks ago
2025. 08. 13. 15:02 keltezéssel, Andy Shevchenko írta:
> On Wed, Aug 13, 2025 at 12:13:26PM +0200, Gabor Juhos wrote:
>> 2025. 08. 11. 22:12 keltezéssel, Andy Shevchenko írta:
>>> On Mon, Aug 11, 2025 at 09:49:54PM +0200, Gabor Juhos wrote:
> 
> ...
> 
>>>> Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
>>>> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
>>>
>>> I didn't get this SoB chain. Who is Imre here and what is his role in all this?
>>
>> Imre reviewed the patches before publishing those, but we were unsure about that
>> the Reviewed-by tag can be used when it is offered privately before the
>> publicaton, so we decided to use the SoB tag instead.
> 
> It's exactly what should have been done. As a such the SoB chain is confusing
> (taking into account the authorship of the patches).

Thanks for confirming!

> 
>> It can be changed to the Rewieved-by tag if that is applicable in this case.
> 
> Please do so.

Ok.

Regards,
Gabor