binder: Add missing module description

[PATCH] binder: Add missing module description

Posted by Salvatore Bonaccorso 1 month, 3 weeks ago

During build modpost issues a warning:

    # MODPOST Module.symvers
       ./scripts/mod/modpost -M -m -b        -o Module.symvers -n -T modules.order vmlinux.o
    WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/android/binder_linux.o

Fix this by adding the missing module description.

Reported-by: Ben Hutchings <benh@debian.org>
Link: https://salsa.debian.org/kernel-team/linux/-/merge_requests/1587
Suggested-by: Ben Hutchings <benh@debian.org>
Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
---
 drivers/android/binder.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 312b462e349d..0c2e38ff3a3b 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -7090,3 +7090,4 @@ device_initcall(binder_init);
 #include "binder_trace.h"
 
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Android Binder IPC Driver");
-- 
2.50.1

Re: [PATCH] binder: Add missing module description

Posted by Carlos Llamas 1 month, 3 weeks ago

On Sat, Aug 09, 2025 at 09:30:18AM +0200, Salvatore Bonaccorso wrote:
> During build modpost issues a warning:
> 
>     # MODPOST Module.symvers
>        ./scripts/mod/modpost -M -m -b        -o Module.symvers -n -T modules.order vmlinux.o
>     WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/android/binder_linux.o
> 
> Fix this by adding the missing module description.

I'm not against having a description but binder is not tristate. Judging
from the 'binder_linux.o' this seems to be some OOT version? Otherwise,
I'm not sure you would be able to reproduce the warn.

> 
> Reported-by: Ben Hutchings <benh@debian.org>
> Link: https://salsa.debian.org/kernel-team/linux/-/merge_requests/1587
> Suggested-by: Ben Hutchings <benh@debian.org>
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> ---
>  drivers/android/binder.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 312b462e349d..0c2e38ff3a3b 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -7090,3 +7090,4 @@ device_initcall(binder_init);
>  #include "binder_trace.h"
>  
>  MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("Android Binder IPC Driver");
> -- 
> 2.50.1
>

Re: [PATCH] binder: Add missing module description

Posted by Salvatore Bonaccorso 1 month, 3 weeks ago

Hi,

On Mon, Aug 11, 2025 at 05:36:20PM +0000, Carlos Llamas wrote:
> On Sat, Aug 09, 2025 at 09:30:18AM +0200, Salvatore Bonaccorso wrote:
> > During build modpost issues a warning:
> > 
> >     # MODPOST Module.symvers
> >        ./scripts/mod/modpost -M -m -b        -o Module.symvers -n -T modules.order vmlinux.o
> >     WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/android/binder_linux.o
> > 
> > Fix this by adding the missing module description.
> 
> I'm not against having a description but binder is not tristate. Judging
> from the 'binder_linux.o' this seems to be some OOT version? Otherwise,
> I'm not sure you would be able to reproduce the warn.

This is entirely my fault. We saw the warning while building in
Debian, but missed that we apply the following patch:
https://salsa.debian.org/kernel-team/linux/-/blob/debian/latest/debian/patches/debian/android-enable-building-binder-as-module.patch?ref_type=heads
which allows to build binder as module.

I got confused by the fact that we have 
MODULE_LICENSE("GPL v2");
in the upstream variant, but no description.

So you want to still have the description added or drop this proposed
patch completely instead?

Regards,
Salvatore

Re: [PATCH] binder: Add missing module description

Posted by Carlos Llamas 1 month, 3 weeks ago

On Mon, Aug 11, 2025 at 08:01:05PM +0200, Salvatore Bonaccorso wrote:
> Hi,
> 
> On Mon, Aug 11, 2025 at 05:36:20PM +0000, Carlos Llamas wrote:
> > On Sat, Aug 09, 2025 at 09:30:18AM +0200, Salvatore Bonaccorso wrote:
> > > During build modpost issues a warning:
> > > 
> > >     # MODPOST Module.symvers
> > >        ./scripts/mod/modpost -M -m -b        -o Module.symvers -n -T modules.order vmlinux.o
> > >     WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/android/binder_linux.o
> > > 
> > > Fix this by adding the missing module description.
> > 
> > I'm not against having a description but binder is not tristate. Judging
> > from the 'binder_linux.o' this seems to be some OOT version? Otherwise,
> > I'm not sure you would be able to reproduce the warn.
> 
> This is entirely my fault. We saw the warning while building in
> Debian, but missed that we apply the following patch:
> https://salsa.debian.org/kernel-team/linux/-/blob/debian/latest/debian/patches/debian/android-enable-building-binder-as-module.patch?ref_type=heads
> which allows to build binder as module.
> 
> I got confused by the fact that we have 
> MODULE_LICENSE("GPL v2");
> in the upstream variant, but no description.
> 
> So you want to still have the description added or drop this proposed
> patch completely instead?

I think it is best to drop all MODULE_* macros and avoid further
confusion. Including the current MODULE_LICENSE(), this is misleading.
I'll send a patch fixing this.

However, I don't see why we couldn't take all those patches to support
binder tristate later on. Assuming that other maintainers would be ok
exporting all those symbols used by binder that is. We are not using
binder as a module but it doesn't hurt either. wdyt?

--
Carlos Llamas

Re: [PATCH] binder: Add missing module description

Posted by Greg Kroah-Hartman 1 month, 2 weeks ago

On Mon, Aug 11, 2025 at 06:44:49PM +0000, Carlos Llamas wrote:
> On Mon, Aug 11, 2025 at 08:01:05PM +0200, Salvatore Bonaccorso wrote:
> > Hi,
> > 
> > On Mon, Aug 11, 2025 at 05:36:20PM +0000, Carlos Llamas wrote:
> > > On Sat, Aug 09, 2025 at 09:30:18AM +0200, Salvatore Bonaccorso wrote:
> > > > During build modpost issues a warning:
> > > > 
> > > >     # MODPOST Module.symvers
> > > >        ./scripts/mod/modpost -M -m -b        -o Module.symvers -n -T modules.order vmlinux.o
> > > >     WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/android/binder_linux.o
> > > > 
> > > > Fix this by adding the missing module description.
> > > 
> > > I'm not against having a description but binder is not tristate. Judging
> > > from the 'binder_linux.o' this seems to be some OOT version? Otherwise,
> > > I'm not sure you would be able to reproduce the warn.
> > 
> > This is entirely my fault. We saw the warning while building in
> > Debian, but missed that we apply the following patch:
> > https://salsa.debian.org/kernel-team/linux/-/blob/debian/latest/debian/patches/debian/android-enable-building-binder-as-module.patch?ref_type=heads
> > which allows to build binder as module.
> > 
> > I got confused by the fact that we have 
> > MODULE_LICENSE("GPL v2");
> > in the upstream variant, but no description.
> > 
> > So you want to still have the description added or drop this proposed
> > patch completely instead?
> 
> I think it is best to drop all MODULE_* macros and avoid further
> confusion. Including the current MODULE_LICENSE(), this is misleading.
> I'll send a patch fixing this.

Please do, that should make it more obvious that this can't be a module.

thanks,

greg k-h

Re: [PATCH] binder: Add missing module description

Posted by Carlos Llamas 1 month, 2 weeks ago

On Sun, Aug 17, 2025 at 11:42:03AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 11, 2025 at 06:44:49PM +0000, Carlos Llamas wrote:
> > I think it is best to drop all MODULE_* macros and avoid further
> > confusion. Including the current MODULE_LICENSE(), this is misleading.
> > I'll send a patch fixing this.
> 
> Please do, that should make it more obvious that this can't be a module.
> 
> thanks,
> 
> greg k-h

Oops, I forgot to hit send. Here it is:

https://lore.kernel.org/all/20250817135034.3692902-1-cmllamas@google.com/

Re: [PATCH] binder: Add missing module description

Posted by Alice Ryhl 1 month, 3 weeks ago

On Sat, Aug 09, 2025 at 09:30:18AM +0200, Salvatore Bonaccorso wrote:
> During build modpost issues a warning:
> 
>     # MODPOST Module.symvers
>        ./scripts/mod/modpost -M -m -b        -o Module.symvers -n -T modules.order vmlinux.o
>     WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/android/binder_linux.o
> 
> Fix this by adding the missing module description.
> 
> Reported-by: Ben Hutchings <benh@debian.org>
> Link: https://salsa.debian.org/kernel-team/linux/-/merge_requests/1587
> Suggested-by: Ben Hutchings <benh@debian.org>
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>