Static analyser cppcheck says:

  linux-6.16/tools/perf/util/tool_pmu.c:242:15: warning:
      Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition]

Source code is

        for (thread = 0; thread < nthreads; thread++) {
            if (thread >= nthreads)
                break;

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/util/tool_pmu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/perf/util/tool_pmu.c b/tools/perf/util/tool_pmu.c
index d99e699e646dd651..f075098488baddd9 100644
--- a/tools/perf/util/tool_pmu.c
+++ b/tools/perf/util/tool_pmu.c
@@ -239,9 +239,6 @@ int evsel__tool_pmu_open(struct evsel *evsel,
 	nthreads = perf_thread_map__nr(threads);
 	for (idx = start_cpu_map_idx; idx < end_cpu_map_idx; idx++) {
 		for (thread = 0; thread < nthreads; thread++) {
-			if (thread >= nthreads)
-				break;
-
 			if (!evsel->cgrp && !evsel->core.system_wide)
 				pid = perf_thread_map__pid(threads, thread);
 
-- 
2.51.0.rc0.155.g4a0f42376b-goog

On Fri, Aug 8, 2025 at 3:26 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Static analyser cppcheck says:
>
>   linux-6.16/tools/perf/util/tool_pmu.c:242:15: warning:
>       Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition]
>
> Source code is
>
>         for (thread = 0; thread < nthreads; thread++) {
>             if (thread >= nthreads)
>                 break;
>
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/util/tool_pmu.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/tools/perf/util/tool_pmu.c b/tools/perf/util/tool_pmu.c
> index d99e699e646dd651..f075098488baddd9 100644
> --- a/tools/perf/util/tool_pmu.c
> +++ b/tools/perf/util/tool_pmu.c
> @@ -239,9 +239,6 @@ int evsel__tool_pmu_open(struct evsel *evsel,
>         nthreads = perf_thread_map__nr(threads);
>         for (idx = start_cpu_map_idx; idx < end_cpu_map_idx; idx++) {
>                 for (thread = 0; thread < nthreads; thread++) {
> -                       if (thread >= nthreads)
> -                               break;
> -
>                         if (!evsel->cgrp && !evsel->core.system_wide)
>                                 pid = perf_thread_map__pid(threads, thread);
>
> --
> 2.51.0.rc0.155.g4a0f42376b-goog
>