[PATCH v1 1/2] ASoC: dt-bindings: qcom,sm8250: Add lemans-evk and monaco-evk sound card

Mohammad Rafi Shaik posted 2 patches 1 month, 4 weeks ago
[PATCH v1 1/2] ASoC: dt-bindings: qcom,sm8250: Add lemans-evk and monaco-evk sound card
Posted by Mohammad Rafi Shaik 1 month, 4 weeks ago
Document the bindings for the Qualcomm LEMANS-EVK and MONACO-EVK
board specific sound card.

The bindings are the same as for other newer Qualcomm ADSP sound cards,
thus keep them in existing qcom,sm8250.yaml file, even though Linux driver
is separate.

Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
index 5d3dbb6cb1ae..c63bfe031b57 100644
--- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
@@ -31,6 +31,8 @@ properties:
           - fairphone,fp4-sndcard
           - fairphone,fp5-sndcard
           - qcom,apq8096-sndcard
+          - qcom,lemans-evk-sndcard
+          - qcom,monaco-evk-sndcard
           - qcom,qcm6490-idp-sndcard
           - qcom,qcs6490-rb3gen2-sndcard
           - qcom,qcs8275-sndcard
-- 
2.34.1
Re: [PATCH v1 1/2] ASoC: dt-bindings: qcom,sm8250: Add lemans-evk and monaco-evk sound card
Posted by Krzysztof Kozlowski 1 month, 3 weeks ago
On 08/08/2025 07:29, Mohammad Rafi Shaik wrote:
> Document the bindings for the Qualcomm LEMANS-EVK and MONACO-EVK
> board specific sound card.
> 
> The bindings are the same as for other newer Qualcomm ADSP sound cards,
> thus keep them in existing qcom,sm8250.yaml file, even though Linux driver
> is separate.
> 
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> index 5d3dbb6cb1ae..c63bfe031b57 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> @@ -31,6 +31,8 @@ properties:
>            - fairphone,fp4-sndcard
>            - fairphone,fp5-sndcard
>            - qcom,apq8096-sndcard
> +          - qcom,lemans-evk-sndcard


Lemans is already there under one of the QCS cards. I was told it is the
same, so you do not get a new compatible.

Monaco maybe as well.

We also name standard cards per SoC, not per board, so evk should be
dropped or commit msg should explain why this is different.


Best regards,
Krzysztof
Re: [PATCH v1 1/2] ASoC: dt-bindings: qcom,sm8250: Add lemans-evk and monaco-evk sound card
Posted by Mohammad Rafi Shaik 1 month, 3 weeks ago

On 8/8/2025 11:44 AM, Krzysztof Kozlowski wrote:
> On 08/08/2025 07:29, Mohammad Rafi Shaik wrote:
>> Document the bindings for the Qualcomm LEMANS-EVK and MONACO-EVK
>> board specific sound card.
>>
>> The bindings are the same as for other newer Qualcomm ADSP sound cards,
>> thus keep them in existing qcom,sm8250.yaml file, even though Linux driver
>> is separate.
>>
>> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
>> ---
>>   Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>> index 5d3dbb6cb1ae..c63bfe031b57 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>> @@ -31,6 +31,8 @@ properties:
>>             - fairphone,fp4-sndcard
>>             - fairphone,fp5-sndcard
>>             - qcom,apq8096-sndcard
>> +          - qcom,lemans-evk-sndcard
> 
> 
> Lemans is already there under one of the QCS cards. I was told it is the
> same, so you do not get a new compatible.
> 
> Monaco maybe as well.
> 
> We also name standard cards per SoC, not per board, so evk should be
> dropped or commit msg should explain why this is different.
> 

Ack,

will remove the EVK and keep the soc compatible.

For Lemans will re-use the qcs9100-sndcard compatible and

for monaco will add the new soc compatible (qcs8300-sndcard) in the same 
series with updated cover-letter and drop the Lemans related change.

Thanks & regards,
Rafi.

> 
> Best regards,
> Krzysztof