[PATCH v2] drm/bridge: cdns-dsi: Remove unnecessary memset

Liao Yuanhong posted 1 patch 1 month, 3 weeks ago
drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 1 -
1 file changed, 1 deletion(-)
[PATCH v2] drm/bridge: cdns-dsi: Remove unnecessary memset
Posted by Liao Yuanhong 1 month, 3 weeks ago
kzalloc() has already been initialized to full 0 space, there is no need to
use memset() to initialize again.

Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
Changes in v2:
	Modify the subject prefix.
---
 drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
index a57ca8c3bdae..590f7c75744e 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
@@ -1047,7 +1047,6 @@ cdns_dsi_bridge_atomic_reset(struct drm_bridge *bridge)
 	if (!dsi_state)
 		return NULL;
 
-	memset(dsi_state, 0, sizeof(*dsi_state));
 	dsi_state->base.bridge = bridge;
 
 	return &dsi_state->base;
-- 
2.34.1
Re: [PATCH v2] drm/bridge: cdns-dsi: Remove unnecessary memset
Posted by Luca Ceresoli 1 month, 3 weeks ago
On Fri,  8 Aug 2025 11:59:37 +0800
Liao Yuanhong <liaoyuanhong@vivo.com> wrote:

> kzalloc() has already been initialized to full 0 space, there is no need to
> use memset() to initialize again.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Re: [PATCH v2] drm/bridge: cdns-dsi: Remove unnecessary memset
Posted by Tomi Valkeinen 1 month, 3 weeks ago
Hi,

On 08/08/2025 06:59, Liao Yuanhong wrote:
> kzalloc() has already been initialized to full 0 space, there is no need to
> use memset() to initialize again.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
> Changes in v2:
> 	Modify the subject prefix.
> ---
>  drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> index a57ca8c3bdae..590f7c75744e 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> @@ -1047,7 +1047,6 @@ cdns_dsi_bridge_atomic_reset(struct drm_bridge *bridge)
>  	if (!dsi_state)
>  		return NULL;
>  
> -	memset(dsi_state, 0, sizeof(*dsi_state));
>  	dsi_state->base.bridge = bridge;
>  
>  	return &dsi_state->base;

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

 Tomi