[PATCH 0/2] gpu: nova-core: vbios: simplify device use

Alexandre Courbot posted 2 patches 1 month, 4 weeks ago
drivers/gpu/nova-core/firmware/fwsec.rs |   8 +-
drivers/gpu/nova-core/gpu.rs            |   2 +-
drivers/gpu/nova-core/vbios.rs          | 168 +++++++++++++++-----------------
3 files changed, 85 insertions(+), 93 deletions(-)
[PATCH 0/2] gpu: nova-core: vbios: simplify device use
Posted by Alexandre Courbot 1 month, 4 weeks ago
This small cleanup series simplifies the use of `Device` in vbios
methods.

The device is used for logging purposes only; thus we don't need a
pci::Device, neither do we need it to be bound. This latter property
allows us to store an `ARef` to it into structures that require logging
instead of having all their methods take an extra `dev` argument.
Removing this argument streamlines the code a bit.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
Alexandre Courbot (2):
      gpu: nova-core: vbios: replace pci::Device with device::Device
      gpu: nova-core: vbios: store reference to Device where relevant

 drivers/gpu/nova-core/firmware/fwsec.rs |   8 +-
 drivers/gpu/nova-core/gpu.rs            |   2 +-
 drivers/gpu/nova-core/vbios.rs          | 168 +++++++++++++++-----------------
 3 files changed, 85 insertions(+), 93 deletions(-)
---
base-commit: 14ae91a81ec8fa0bc23170d4aa16dd2a20d54105
change-id: 20250808-vbios_device-b0a912aff149

Best regards,
-- 
Alexandre Courbot <acourbot@nvidia.com>
Re: [PATCH 0/2] gpu: nova-core: vbios: simplify device use
Posted by Danilo Krummrich 1 month ago
On 8/8/25 4:46 AM, Alexandre Courbot wrote:
> This small cleanup series simplifies the use of `Device` in vbios
> methods.
> 
> The device is used for logging purposes only; thus we don't need a
> pci::Device, neither do we need it to be bound. This latter property
> allows us to store an `ARef` to it into structures that require logging
> instead of having all their methods take an extra `dev` argument.
> Removing this argument streamlines the code a bit.
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>

Acked-by: Danilo Krummrich <dakr@kernel.org>
Re: [PATCH 0/2] gpu: nova-core: vbios: simplify device use
Posted by Alexandre Courbot 1 month ago
On Mon Sep 1, 2025 at 7:37 PM JST, Danilo Krummrich wrote:
> On 8/8/25 4:46 AM, Alexandre Courbot wrote:
>> This small cleanup series simplifies the use of `Device` in vbios
>> methods.
>> 
>> The device is used for logging purposes only; thus we don't need a
>> pci::Device, neither do we need it to be bound. This latter property
>> allows us to store an `ARef` to it into structures that require logging
>> instead of having all their methods take an extra `dev` argument.
>> Removing this argument streamlines the code a bit.
>> 
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>
> Acked-by: Danilo Krummrich <dakr@kernel.org>

Thanks! Pushed into nova-next.