nfs: more client side tracepoints in write and writeback codepaths

[PATCH 0/5] nfs: more client side tracepoints in write and writeback codepaths

Posted by Jeff Layton 4 months, 1 week ago

This is a pile of tracepoint additions and cleanups. Most of these I
plumbed in while tracking down the recent client-side corruption I've
been hunting. Please consider for v6.18.

Thanks,

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Jeff Layton (5):
      nfs: remove trailing space from tracepoint
      nfs: add tracepoints to nfs_file_read() and nfs_file_write()
      nfs: new tracepoints around write handling
      nfs: more in-depth tracing of writepage events
      nfs: add tracepoints to nfs_writepages()

 fs/nfs/file.c     |  20 ++++++--
 fs/nfs/nfstrace.h | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
 fs/nfs/write.c    |  22 +++++++--
 3 files changed, 168 insertions(+), 9 deletions(-)
---
base-commit: 0919a5b3b11c699d23bc528df5709f2e3213f6a9
change-id: 20250807-nfs-tracepoints-f1d84186564d

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH 0/5] nfs: more client side tracepoints in write and writeback codepaths

Posted by Jeff Layton 3 months, 2 weeks ago

On Fri, 2025-08-08 at 07:40 -0400, Jeff Layton wrote:
> This is a pile of tracepoint additions and cleanups. Most of these I
> plumbed in while tracking down the recent client-side corruption I've
> been hunting. Please consider for v6.18.
> 
> Thanks,
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> Jeff Layton (5):
>       nfs: remove trailing space from tracepoint
>       nfs: add tracepoints to nfs_file_read() and nfs_file_write()
>       nfs: new tracepoints around write handling
>       nfs: more in-depth tracing of writepage events
>       nfs: add tracepoints to nfs_writepages()
> 
>  fs/nfs/file.c     |  20 ++++++--
>  fs/nfs/nfstrace.h | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  fs/nfs/write.c    |  22 +++++++--
>  3 files changed, 168 insertions(+), 9 deletions(-)
> ---
> base-commit: 0919a5b3b11c699d23bc528df5709f2e3213f6a9
> change-id: 20250807-nfs-tracepoints-f1d84186564d
> 
> Best regards,

Ping? I haven't seen a response, or these in linux-next yet. Can we get
them in soon so they can make v6.18?

They were pretty helpful for tracking down that pgio fix recently.

Thanks,
-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH 0/5] nfs: more client side tracepoints in write and writeback codepaths

Posted by Anna Schumaker 3 months, 1 week ago


On 8/29/25 10:45 AM, Jeff Layton wrote:
> On Fri, 2025-08-08 at 07:40 -0400, Jeff Layton wrote:
>> This is a pile of tracepoint additions and cleanups. Most of these I
>> plumbed in while tracking down the recent client-side corruption I've
>> been hunting. Please consider for v6.18.
>>
>> Thanks,
>>
>> Signed-off-by: Jeff Layton <jlayton@kernel.org>
>> ---
>> Jeff Layton (5):
>>       nfs: remove trailing space from tracepoint
>>       nfs: add tracepoints to nfs_file_read() and nfs_file_write()
>>       nfs: new tracepoints around write handling
>>       nfs: more in-depth tracing of writepage events
>>       nfs: add tracepoints to nfs_writepages()
>>
>>  fs/nfs/file.c     |  20 ++++++--
>>  fs/nfs/nfstrace.h | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>  fs/nfs/write.c    |  22 +++++++--
>>  3 files changed, 168 insertions(+), 9 deletions(-)
>> ---
>> base-commit: 0919a5b3b11c699d23bc528df5709f2e3213f6a9
>> change-id: 20250807-nfs-tracepoints-f1d84186564d
>>
>> Best regards,
> 
> Ping? I haven't seen a response, or these in linux-next yet. Can we get
> them in soon so they can make v6.18?

Hi Jeff,

They look good to me, and I'm planning on taking them for 6.18.

Anna

> 
> They were pretty helpful for tracking down that pgio fix recently.
> 
> Thanks,

Re: [PATCH 0/5] nfs: more client side tracepoints in write and writeback codepaths

Posted by Benjamin Coddington 4 months, 1 week ago

On 8 Aug 2025, at 7:40, Jeff Layton wrote:

> This is a pile of tracepoint additions and cleanups. Most of these I
> plumbed in while tracking down the recent client-side corruption I've
> been hunting. Please consider for v6.18.
>
> Thanks,
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> Jeff Layton (5):
>       nfs: remove trailing space from tracepoint
>       nfs: add tracepoints to nfs_file_read() and nfs_file_write()
>       nfs: new tracepoints around write handling
>       nfs: more in-depth tracing of writepage events
>       nfs: add tracepoints to nfs_writepages()
>
>  fs/nfs/file.c     |  20 ++++++--
>  fs/nfs/nfstrace.h | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  fs/nfs/write.c    |  22 +++++++--
>  3 files changed, 168 insertions(+), 9 deletions(-)
> ---
> base-commit: 0919a5b3b11c699d23bc528df5709f2e3213f6a9
> change-id: 20250807-nfs-tracepoints-f1d84186564d
>
> Best regards,
> -- 
> Jeff Layton <jlayton@kernel.org>


These look great.

Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

Ben