[PATCH net v3 00/16] net: macb: various fixes & cleanup

Théo Lebrun posted 16 patches 1 month, 3 weeks ago
.../devicetree/bindings/net/cdns,macb.yaml         |  10 +-
drivers/net/ethernet/cadence/macb.h                |  75 +++---
drivers/net/ethernet/cadence/macb_main.c           | 288 +++++++++------------
drivers/net/ethernet/cadence/macb_ptp.c            |  16 +-
4 files changed, 174 insertions(+), 215 deletions(-)
[PATCH net v3 00/16] net: macb: various fixes & cleanup
Posted by Théo Lebrun 1 month, 3 weeks ago
This is a split off my previous series on MACB [0]. The main goal is to
add EyeQ5 support, but there was a lot of independent fixes/cleanup.

Overall, it is fixes first so they can be applied swiftly, followed by a
series of cleanup patches. To clarify, nothing critical. It mostly puts
the driver in a better shape and prepares it for EyeQ5 patches.

Thanks,
Have a nice day,
Théo

[0]: https://lore.kernel.org/lkml/20250627-macb-v2-0-ff8207d0bb77@bootlin.com/

Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
Changes in v3:
- Cover letter: drop addresses that reject emails:
  cyrille.pitchen@atmel.com
  hskinnemoen@atmel.com
  jeff@garzik.org
  rafalo@cadence.com
- dt-bindings: Take 2x Reviewed-by Krzysztof.
- dt-bindings: add Fixes trailer to "allow tsu_clk without tx_clk"
  patch, to highlight we are not introducing new behavior.
- Reorder commits; move fixes first followed by cleanup patches.
- Drop all EyeQ5 related commits.
- New commit: "remove gap in MACB_CAPS_* flags".
- New commit: "move ring size computation to functions".
- New commit: "move bp->hw_dma_cap flags to bp->caps".
- Rename introduced helpers macb_dma_is_64b() to macb_dma64() and,
  macb_dma_is_ptp() to macb_dma_ptp().
- Rename MACB_CAPS_RSC_CAPABLE -> MACB_CAPS_RSC.
- Fix commit message typos: "maxime" -> "maximise", etc.
- Take 7x Reviewed-by: Sean Anderson.
- Add details to some commit messages.
- Link to v2: https://lore.kernel.org/r/20250627-macb-v2-0-ff8207d0bb77@bootlin.com

---
Théo Lebrun (16):
      dt-bindings: net: cdns,macb: allow tsu_clk without tx_clk
      dt-bindings: net: cdns,macb: sort compatibles
      net: macb: remove illusion about TBQPH/RBQPH being per-queue
      net: macb: move ring size computation to functions
      net: macb: single dma_alloc_coherent() for DMA descriptors
      net: macb: match skb_reserve(skb, NET_IP_ALIGN) with HW alignment
      net: macb: avoid double endianness swap in macb_set_hwaddr()
      net: macb: use BIT() macro for capability definitions
      net: macb: remove gap in MACB_CAPS_* flags
      net: macb: Remove local variables clk_init and init in macb_probe()
      net: macb: drop macb_config NULL checking
      net: macb: simplify macb_dma_desc_get_size()
      net: macb: simplify macb_adj_dma_desc_idx()
      net: macb: move bp->hw_dma_cap flags to bp->caps
      net: macb: introduce DMA descriptor helpers (is 64bit? is PTP?)
      net: macb: sort #includes

 .../devicetree/bindings/net/cdns,macb.yaml         |  10 +-
 drivers/net/ethernet/cadence/macb.h                |  75 +++---
 drivers/net/ethernet/cadence/macb_main.c           | 288 +++++++++------------
 drivers/net/ethernet/cadence/macb_ptp.c            |  16 +-
 4 files changed, 174 insertions(+), 215 deletions(-)
---
base-commit: 37816488247ddddbc3de113c78c83572274b1e2e
change-id: 20250808-macb-fixes-e2f570e11241

Best regards,
-- 
Théo Lebrun <theo.lebrun@bootlin.com>

Re: [PATCH net v3 00/16] net: macb: various fixes & cleanup
Posted by Jakub Kicinski 1 month, 3 weeks ago
On Fri, 08 Aug 2025 18:52:32 +0200 Théo Lebrun wrote:
> This is a split off my previous series on MACB [0]. The main goal is to
> add EyeQ5 support, but there was a lot of independent fixes/cleanup.
> 
> Overall, it is fixes first so they can be applied swiftly, followed by a
> series of cleanup patches. To clarify, nothing critical. It mostly puts
> the driver in a better shape and prepares it for EyeQ5 patches.

Nothing past patch 7 is a fix, please separate fixes from other changes
(unless there's a hard to avoid dependency). Please wrap the code at 80
chars.
-- 
pw-bot: cr