[PATCH v6 00/12] perf: arm_spe: Armv8.8 SPE features

James Clark posted 12 patches 4 months, 1 week ago
There is a newer version of this series
Documentation/arch/arm64/booting.rst      |  11 +++
arch/arm64/include/asm/el2_setup.h        |  28 ++++--
arch/arm64/include/asm/sysreg.h           |   9 --
arch/arm64/include/asm/vncr_mapping.h     |   2 +
arch/arm64/kvm/emulate-nested.c           |   1 +
arch/arm64/kvm/sys_regs.c                 |   1 +
arch/arm64/tools/sysreg                   |  13 ++-
drivers/perf/arm_spe_pmu.c                | 148 ++++++++++++++++++++++++++----
include/uapi/linux/perf_event.h           |   2 +
tools/include/uapi/linux/perf_event.h     |   2 +
tools/perf/Documentation/perf-arm-spe.txt | 104 +++++++++++++++++++--
tools/perf/tests/parse-events.c           |  14 ++-
tools/perf/util/parse-events.c            |  11 +++
tools/perf/util/parse-events.h            |   1 +
tools/perf/util/parse-events.l            |   1 +
tools/perf/util/pmu.c                     |   8 ++
tools/perf/util/pmu.h                     |   1 +
17 files changed, 312 insertions(+), 45 deletions(-)
[PATCH v6 00/12] perf: arm_spe: Armv8.8 SPE features
Posted by James Clark 4 months, 1 week ago
Support 3 new SPE features: FEAT_SPEv1p4 filters, FEAT_SPE_EFT extended
filtering, and SPE_FEAT_FDS data source filtering. The features are
independent can be applied separately:

  * Prerequisite sysreg changes - patch 1
  * FEAT_SPEv1p4 - patches 2 - 3
  * FEAT_SPE_EFT - patch 4
  * FEAT_SPE_FDS - patches 5 - 9
  * FEAT_SPE_FDS Perf tool changes - patches 10 - 12

The first two features will work with old Perfs but a Perf change to
parse the new config4 is required for the last feature.

---
Changes in v6:
- Rebase to resolve conflict with BRBE changes in el2_setup.h
- Link to v5: https://lore.kernel.org/r/20250721-james-perf-feat_spe_eft-v5-0-a7bc533485a1@linaro.org

Changes in v5:
- Forgot to pickup tags from v4
- Forgot to drop test and review tags on v4 patches that were
  significantly modified
- Update commit message for data source filtering to mention inversion
- Link to v4: https://lore.kernel.org/r/20250721-james-perf-feat_spe_eft-v4-0-0a527410f8fd@linaro.org

Changes in v4:
- Rewrite "const u64 feat_spe_eft_bits" inline
- Invert data source filter so that it's possible to exclude all data
  sources without adding an additional 'enable filter' flag
- Add a macro in el2_setup.h to check for an SPE version
- Probe valid filter bits instead of hardcoding them
- Take in Leo's commit to expose the filter bits as it depends on the
  new filter probing
- Link to v3: https://lore.kernel.org/r/20250605-james-perf-feat_spe_eft-v3-0-71b0c9f98093@linaro.org

Changes in v3:
- Use PMSIDR_EL1_FDS instead of 1 << PMSIDR_EL1_FDS_SHIFT
- Add VNCR offsets
- Link to v2: https://lore.kernel.org/r/20250529-james-perf-feat_spe_eft-v2-0-a01a9baad06a@linaro.org

Changes in v2:
- Fix detection of FEAT_SPE_FDS in el2_setup.h
- Pickup Marc Z's sysreg change instead which matches the json
- Restructure and expand docs changes
- Link to v1: https://lore.kernel.org/r/20250506-james-perf-feat_spe_eft-v1-0-dd480e8e4851@linaro.org

---
James Clark (11):
      arm64: sysreg: Add new PMSFCR_EL1 fields and PMSDSFR_EL1 register
      perf: arm_spe: Support FEAT_SPEv1p4 filters
      perf: arm_spe: Add support for FEAT_SPE_EFT extended filtering
      arm64/boot: Factor out a macro to check SPE version
      arm64/boot: Enable EL2 requirements for SPE_FEAT_FDS
      KVM: arm64: Add trap configs for PMSDSFR_EL1
      perf: Add perf_event_attr::config4
      perf: arm_spe: Add support for filtering on data source
      tools headers UAPI: Sync linux/perf_event.h with the kernel sources
      perf tools: Add support for perf_event_attr::config4
      perf docs: arm-spe: Document new SPE filtering features

Leo Yan (1):
      perf: arm_spe: Expose event filter

 Documentation/arch/arm64/booting.rst      |  11 +++
 arch/arm64/include/asm/el2_setup.h        |  28 ++++--
 arch/arm64/include/asm/sysreg.h           |   9 --
 arch/arm64/include/asm/vncr_mapping.h     |   2 +
 arch/arm64/kvm/emulate-nested.c           |   1 +
 arch/arm64/kvm/sys_regs.c                 |   1 +
 arch/arm64/tools/sysreg                   |  13 ++-
 drivers/perf/arm_spe_pmu.c                | 148 ++++++++++++++++++++++++++----
 include/uapi/linux/perf_event.h           |   2 +
 tools/include/uapi/linux/perf_event.h     |   2 +
 tools/perf/Documentation/perf-arm-spe.txt | 104 +++++++++++++++++++--
 tools/perf/tests/parse-events.c           |  14 ++-
 tools/perf/util/parse-events.c            |  11 +++
 tools/perf/util/parse-events.h            |   1 +
 tools/perf/util/parse-events.l            |   1 +
 tools/perf/util/pmu.c                     |   8 ++
 tools/perf/util/pmu.h                     |   1 +
 17 files changed, 312 insertions(+), 45 deletions(-)
---
base-commit: 37816488247ddddbc3de113c78c83572274b1e2e
change-id: 20250312-james-perf-feat_spe_eft-66cdf4d8fe99

Best regards,
-- 
James Clark <james.clark@linaro.org>
Re: [PATCH v6 00/12] perf: arm_spe: Armv8.8 SPE features
Posted by Leo Yan 4 months, 1 week ago
On Fri, Aug 08, 2025 at 12:22:57PM +0100, James Clark wrote:
> Support 3 new SPE features: FEAT_SPEv1p4 filters, FEAT_SPE_EFT extended
> filtering, and SPE_FEAT_FDS data source filtering. The features are
> independent can be applied separately:
> 
>   * Prerequisite sysreg changes - patch 1
>   * FEAT_SPEv1p4 - patches 2 - 3
>   * FEAT_SPE_EFT - patch 4
>   * FEAT_SPE_FDS - patches 5 - 9
>   * FEAT_SPE_FDS Perf tool changes - patches 10 - 12
> 
> The first two features will work with old Perfs but a Perf change to
> parse the new config4 is required for the last feature.

I tested FEAT_SPE_EFT (xxx_filter_mask), inv_data_src_filter
and inv_event_filter, all of them work as expected.

Tested-by: Leo Yan <leo.yan@arm.com>
Re: [PATCH v6 00/12] perf: arm_spe: Armv8.8 SPE features
Posted by Arnaldo Carvalho de Melo 3 months ago
On Fri, Aug 08, 2025 at 01:39:13PM +0100, Leo Yan wrote:
> On Fri, Aug 08, 2025 at 12:22:57PM +0100, James Clark wrote:
> > Support 3 new SPE features: FEAT_SPEv1p4 filters, FEAT_SPE_EFT extended
> > filtering, and SPE_FEAT_FDS data source filtering. The features are
> > independent can be applied separately:
> > 
> >   * Prerequisite sysreg changes - patch 1
> >   * FEAT_SPEv1p4 - patches 2 - 3
> >   * FEAT_SPE_EFT - patch 4
> >   * FEAT_SPE_FDS - patches 5 - 9
> >   * FEAT_SPE_FDS Perf tool changes - patches 10 - 12
> > 
> > The first two features will work with old Perfs but a Perf change to
> > parse the new config4 is required for the last feature.
> 
> I tested FEAT_SPE_EFT (xxx_filter_mask), inv_data_src_filter
> and inv_event_filter, all of them work as expected.
> 
> Tested-by: Leo Yan <leo.yan@arm.com>

Please let me know when I can merge the tools/perf bits.

- Arnaldo
Re: [PATCH v6 00/12] perf: arm_spe: Armv8.8 SPE features
Posted by Leo Yan 3 months ago
On Wed, Sep 17, 2025 at 02:24:29PM -0300, Arnaldo Carvalho de Melo wrote:
> On Fri, Aug 08, 2025 at 01:39:13PM +0100, Leo Yan wrote:
> > On Fri, Aug 08, 2025 at 12:22:57PM +0100, James Clark wrote:
> > > Support 3 new SPE features: FEAT_SPEv1p4 filters, FEAT_SPE_EFT extended
> > > filtering, and SPE_FEAT_FDS data source filtering. The features are
> > > independent can be applied separately:
> > > 
> > >   * Prerequisite sysreg changes - patch 1
> > >   * FEAT_SPEv1p4 - patches 2 - 3
> > >   * FEAT_SPE_EFT - patch 4
> > >   * FEAT_SPE_FDS - patches 5 - 9
> > >   * FEAT_SPE_FDS Perf tool changes - patches 10 - 12
> > > 
> > > The first two features will work with old Perfs but a Perf change to
> > > parse the new config4 is required for the last feature.
> > 
> > I tested FEAT_SPE_EFT (xxx_filter_mask), inv_data_src_filter
> > and inv_event_filter, all of them work as expected.
> > 
> > Tested-by: Leo Yan <leo.yan@arm.com>
> 
> Please let me know when I can merge the tools/perf bits.

Thanks for bringing up this, Arnaldo!

Just remind, James sent the latest series is v8 [1] couple weeks ago,
and I confirmed v8 can apply clearly on the latest mainline kernel.
We need kernel maintainers' review so can move forward.

Thanks,
Leo

[1] https://lore.kernel.org/linux-arm-kernel/20250901-james-perf-feat_spe_eft-v8-0-2e2738f24559@linaro.org/