[PATCH] dt-bindings: mfd: aspeed-lpc: Add missing "clocks" property on lpc-snoop node

Rob Herring (Arm) posted 1 patch 1 month, 4 weeks ago
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml | 3 +++
1 file changed, 3 insertions(+)
[PATCH] dt-bindings: mfd: aspeed-lpc: Add missing "clocks" property on lpc-snoop node
Posted by Rob Herring (Arm) 1 month, 4 weeks ago
The ASpeed lpc-snoop nodes have a "clocks" property which isn't
documented. It looks like all the LPC child devices have the same clock
source. Perhaps it is the parent device that should have the clock, but
it's too late for that. The driver for lpc-snoop requires a clock to be
present.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml b/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
index d88854e60b7f..f329223cec07 100644
--- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
+++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
@@ -137,6 +137,9 @@ patternProperties:
       reg:
         maxItems: 1
 
+      clocks:
+        maxItems: 1
+
       interrupts:
         maxItems: 1
 
-- 
2.47.2
Re: (subset) [PATCH] dt-bindings: mfd: aspeed-lpc: Add missing "clocks" property on lpc-snoop node
Posted by Lee Jones 1 month ago
On Thu, 07 Aug 2025 08:29:08 -0500, Rob Herring (Arm) wrote:
> The ASpeed lpc-snoop nodes have a "clocks" property which isn't
> documented. It looks like all the LPC child devices have the same clock
> source. Perhaps it is the parent device that should have the clock, but
> it's too late for that. The driver for lpc-snoop requires a clock to be
> present.
> 
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: mfd: aspeed-lpc: Add missing "clocks" property on lpc-snoop node
      commit: 737b9ec4514ea0423eb049a3c27d8a22d61d03b5

--
Lee Jones [李琼斯]

Re: [PATCH] dt-bindings: mfd: aspeed-lpc: Add missing "clocks" property on lpc-snoop node
Posted by Andrew Jeffery 1 month, 4 weeks ago
On Thu, 2025-08-07 at 08:29 -0500, Rob Herring (Arm) wrote:
> The ASpeed lpc-snoop nodes have a "clocks" property which isn't
> documented. It looks like all the LPC child devices have the same clock
> source. Perhaps it is the parent device that should have the clock, but
> it's too late for that. The driver for lpc-snoop requires a clock to be
> present.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Thanks Rob.

Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>