The MSI controller on SG2044 has the ability to allocate
multiple PCI MSI interrupt if the controller supports it.
Add the missing flag so the controller can make full use
of it.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 drivers/irqchip/irq-sg2042-msi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-sg2042-msi.c b/drivers/irqchip/irq-sg2042-msi.c
index 2b7ee17232ab..6efb34a91937 100644
--- a/drivers/irqchip/irq-sg2042-msi.c
+++ b/drivers/irqchip/irq-sg2042-msi.c
@@ -212,6 +212,7 @@ static const struct msi_parent_ops sg2042_msi_parent_ops = {
 				   MSI_FLAG_PCI_MSI_STARTUP_PARENT)
 
 #define SG2044_MSI_FLAGS_SUPPORTED (MSI_GENERIC_FLAGS_MASK |	\
+				    MSI_FLAG_MULTI_PCI_MSI |	\
 				    MSI_FLAG_PCI_MSIX)
 
 static const struct msi_parent_ops sg2044_msi_parent_ops = {
-- 
2.50.1

On Thu, Aug 07 2025 at 19:23, Inochi Amaoto wrote:

> The MSI controller on SG2044 has the ability to allocate
> multiple PCI MSI interrupt if the controller supports it.

interrupts ...

Which controller?

if the PCI device supports multi MSI.

> Add the missing flag so the controller can make full use
> of it.

Again, the controller does not make use of it. The controller supports
it and the device driver can use it if both the PCI device and the
underlying MSI controller support it.

On Mon, Aug 11, 2025 at 04:33:06PM +0200, Thomas Gleixner wrote:
> On Thu, Aug 07 2025 at 19:23, Inochi Amaoto wrote:
> 
> > The MSI controller on SG2044 has the ability to allocate
> > multiple PCI MSI interrupt if the controller supports it.
> 
> interrupts ...
> 
> Which controller?
> 
> if the PCI device supports multi MSI.
> 

The PCIe controller, in detail, the Synopsys DesignWare PCIe controller.
I will update the comment.

> > Add the missing flag so the controller can make full use
> > of it.
> 
> Again, the controller does not make use of it. The controller supports
> it and the device driver can use it if both the PCI device and the
> underlying MSI controller support it.
> 
>

On Tue, Aug 12, 2025 at 06:36:20AM +0800, Inochi Amaoto wrote:
> On Mon, Aug 11, 2025 at 04:33:06PM +0200, Thomas Gleixner wrote:
> > On Thu, Aug 07 2025 at 19:23, Inochi Amaoto wrote:
> > 
> > > The MSI controller on SG2044 has the ability to allocate
> > > multiple PCI MSI interrupt if the controller supports it.
> > 
> > interrupts ...
> > 
> > Which controller?
> > 
> > if the PCI device supports multi MSI.
> > 
> 
> The PCIe controller, in detail, the Synopsys DesignWare PCIe controller.
> I will update the comment.

This is still too short, I mean if the PCIe controller also supports 
this feature, so the MSI controller and the PCIe device driver can
negotiate and then use this feature.

> 
> > > Add the missing flag so the controller can make full use
> > > of it.
> > 
> > Again, the controller does not make use of it. The controller supports
> > it and the device driver can use it if both the PCI device and the
> > underlying MSI controller support it.
> > 

Yeah, this does thing I want to describe.

Regards,
Inochi