[v2] iio: adc: ad799x: reference voltage capability

[PATCH v2 0/2] iio: adc: ad799x: reference voltage capability

Posted by Stefano Manni 1 month, 4 weeks ago

This patch series refactors 6b104e7895ab16b9b7f466c5f2ca282b87f661e8
in order to add the capability of the chip to have an
external reference voltage into the chip_info struct.
And so avoid ugly conditional checks on the chip id.

In addition the AD7994 is marked to have the external
reference voltage as well.

Changes in v2 compared to v1 [1]:
* remove has_vref from the chips that do not support it,
  rely on the default false value
* remove useless message "Supplied reference not supported"
  shown for all the chips with has_vref = false
* refactor check on regulator being err or zero
* add external reference to ad7994 as oneliner

[1] https://lore.kernel.org/linux-iio/20250806090158.117628-1-stefano.manni@gmail.com/

Stefano Manni (2):
  iio: adc: ad799x: add reference voltage capability to chip_info
  iio: adc: ad799x: add reference voltage to ad7994

 drivers/iio/adc/ad799x.c | 30 +++++++++++++-----------------
 1 file changed, 13 insertions(+), 17 deletions(-)

-- 
2.48.1

Re: [PATCH v2 0/2] iio: adc: ad799x: reference voltage capability

Posted by David Lechner 1 month, 4 weeks ago

On 8/7/25 2:48 AM, Stefano Manni wrote:
> This patch series refactors 6b104e7895ab16b9b7f466c5f2ca282b87f661e8
> in order to add the capability of the chip to have an
> external reference voltage into the chip_info struct.
> And so avoid ugly conditional checks on the chip id.
> 
> In addition the AD7994 is marked to have the external
> reference voltage as well.
> 
> Changes in v2 compared to v1 [1]:
> * remove has_vref from the chips that do not support it,
>   rely on the default false value
> * remove useless message "Supplied reference not supported"
>   shown for all the chips with has_vref = false
> * refactor check on regulator being err or zero
> * add external reference to ad7994 as oneliner
> 
> [1] https://lore.kernel.org/linux-iio/20250806090158.117628-1-stefano.manni@gmail.com/
> 
> Stefano Manni (2):
>   iio: adc: ad799x: add reference voltage capability to chip_info
>   iio: adc: ad799x: add reference voltage to ad7994
> 
>  drivers/iio/adc/ad799x.c | 30 +++++++++++++-----------------
>  1 file changed, 13 insertions(+), 17 deletions(-)
> 

Reviewed-by: David Lechner <dlechner@baylibre.com>

Re: [PATCH v2 0/2] iio: adc: ad799x: reference voltage capability

Posted by Jonathan Cameron 1 month, 3 weeks ago

On Thu, 7 Aug 2025 10:47:29 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 8/7/25 2:48 AM, Stefano Manni wrote:
> > This patch series refactors 6b104e7895ab16b9b7f466c5f2ca282b87f661e8
> > in order to add the capability of the chip to have an
> > external reference voltage into the chip_info struct.
> > And so avoid ugly conditional checks on the chip id.
> > 
> > In addition the AD7994 is marked to have the external
> > reference voltage as well.
> > 
> > Changes in v2 compared to v1 [1]:
> > * remove has_vref from the chips that do not support it,
> >   rely on the default false value
> > * remove useless message "Supplied reference not supported"
> >   shown for all the chips with has_vref = false
> > * refactor check on regulator being err or zero
> > * add external reference to ad7994 as oneliner
> > 
> > [1] https://lore.kernel.org/linux-iio/20250806090158.117628-1-stefano.manni@gmail.com/
> > 
> > Stefano Manni (2):
> >   iio: adc: ad799x: add reference voltage capability to chip_info
> >   iio: adc: ad799x: add reference voltage to ad7994
> > 
> >  drivers/iio/adc/ad799x.c | 30 +++++++++++++-----------------
> >  1 file changed, 13 insertions(+), 17 deletions(-)
> >   
> 
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> 
Applied to the testing branch of iio.git.  I'll rebase on rc1 once
it's available.

thanks,

Jonathan