[PATCH 07/10] media: s5p-mfc: Modify compatible string check for SoC-specific support

Aakarsh Jain posted 10 patches 1 month, 4 weeks ago
[PATCH 07/10] media: s5p-mfc: Modify compatible string check for SoC-specific support
Posted by Aakarsh Jain 1 month, 4 weeks ago
Modify the compatible string handling in the MFC driver
to explicitly match SoC-specific identifiers.

Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
index 73fdcd362265..d13770058e63 100644
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
@@ -1711,22 +1711,22 @@ static const struct of_device_id exynos_mfc_match[] = {
 		.compatible = "samsung,mfc-v5",
 		.data = &mfc_drvdata_v5,
 	}, {
-		.compatible = "samsung,mfc-v6",
+		.compatible = "samsung,exynos5250-mfc",
 		.data = &mfc_drvdata_v6,
 	}, {
-		.compatible = "samsung,mfc-v7",
+		.compatible = "samsung,exynos5420-mfc",
 		.data = &mfc_drvdata_v7,
 	}, {
 		.compatible = "samsung,exynos3250-mfc",
 		.data = &mfc_drvdata_v7_3250,
 	}, {
-		.compatible = "samsung,mfc-v8",
+		.compatible = "samsung,exynos5800-mfc",
 		.data = &mfc_drvdata_v8,
 	}, {
 		.compatible = "samsung,exynos5433-mfc",
 		.data = &mfc_drvdata_v8_5433,
 	}, {
-		.compatible = "samsung,mfc-v10",
+		.compatible = "samsung,exynos7880-mfc",
 		.data = &mfc_drvdata_v10,
 	}, {
 		.compatible = "tesla,fsd-mfc",
-- 
2.49.0
Re: [PATCH 07/10] media: s5p-mfc: Modify compatible string check for SoC-specific support
Posted by Krzysztof Kozlowski 1 month, 4 weeks ago
On 07/08/2025 05:24, Aakarsh Jain wrote:
> Modify the compatible string handling in the MFC driver
> to explicitly match SoC-specific identifiers.
> 
> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>

Please read maintainer soc profile, submitting patches in DT dir and
writing bindings. You just broke all platforms without even admitting it
and without providing rationale.

Best regards,
Krzysztof