[PATCH v2 0/2] drm: vc4: Add support for additional 10/12/16bit YUV plane formats

Dave Stevenson posted 2 patches 1 month, 4 weeks ago
drivers/gpu/drm/vc4/vc4_plane.c | 56 +++++++++++++++++++++++++++++++++++------
drivers/gpu/drm/vc4/vc4_regs.h  |  9 +++++++
2 files changed, 58 insertions(+), 7 deletions(-)
[PATCH v2 0/2] drm: vc4: Add support for additional 10/12/16bit YUV plane formats
Posted by Dave Stevenson 1 month, 4 weeks ago
We'd been asked if the S01x YUV formats could be supported on Pi5 as some
software codecs produce them.
The answer was yes, so this patch adds them and the P01x formats.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
Changes in v2:
- Swapped from adding an extra bool hvs6_only to having a min_gen for
  each format (suggested by Maíra)
- Link to v1: https://lore.kernel.org/r/20250724-drm-vc4-extra-formats-v1-1-67fa80597fad@raspberrypi.com

---
Dave Stevenson (2):
      drm/vc4: plane: Flag formats as having a minimum generation
      drm/vc4: plane: Add support for P01[026] and S01[026] formats

 drivers/gpu/drm/vc4/vc4_plane.c | 56 +++++++++++++++++++++++++++++++++++------
 drivers/gpu/drm/vc4/vc4_regs.h  |  9 +++++++
 2 files changed, 58 insertions(+), 7 deletions(-)
---
base-commit: d2b48f2b30f25997a1ae1ad0cefac68c25f8c330
change-id: 20250724-drm-vc4-extra-formats-1f53e6491cc1

Best regards,
-- 
Dave Stevenson <dave.stevenson@raspberrypi.com>

Re: [PATCH v2 0/2] drm: vc4: Add support for additional 10/12/16bit YUV plane formats
Posted by Robert Mader 1 month, 2 weeks ago
On 07.08.25 15:28, Dave Stevenson wrote:
> We'd been asked if the S01x YUV formats could be supported on Pi5 as some
> software codecs produce them.
> The answer was yes, so this patch adds them and the P01x formats.

I tested this with the Gstreamer MR from 1 and can confirm that the 
formats P010, P012, P016, S010 and S012 work as expected.

Unfortunately S016 is not supported by Gstreamer yet - however chances 
seem high that it works as well.

Thus the series is:

Tested-by: Robert Mader <robert.mader@collabora.com>

1: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8540

>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
> Changes in v2:
> - Swapped from adding an extra bool hvs6_only to having a min_gen for
>    each format (suggested by Maíra)
> - Link to v1: https://lore.kernel.org/r/20250724-drm-vc4-extra-formats-v1-1-67fa80597fad@raspberrypi.com
>
> ---
> Dave Stevenson (2):
>        drm/vc4: plane: Flag formats as having a minimum generation
>        drm/vc4: plane: Add support for P01[026] and S01[026] formats
>
>   drivers/gpu/drm/vc4/vc4_plane.c | 56 +++++++++++++++++++++++++++++++++++------
>   drivers/gpu/drm/vc4/vc4_regs.h  |  9 +++++++
>   2 files changed, 58 insertions(+), 7 deletions(-)
> ---
> base-commit: d2b48f2b30f25997a1ae1ad0cefac68c25f8c330
> change-id: 20250724-drm-vc4-extra-formats-1f53e6491cc1
>
> Best regards,

-- 
Robert Mader
Consultant Software Developer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718

Re: [PATCH v2 0/2] drm: vc4: Add support for additional 10/12/16bit YUV plane formats
Posted by Dave Stevenson 1 month, 2 weeks ago
Hi Robert

On Mon, 18 Aug 2025 at 11:46, Robert Mader <robert.mader@collabora.com> wrote:
>
> On 07.08.25 15:28, Dave Stevenson wrote:
> > We'd been asked if the S01x YUV formats could be supported on Pi5 as some
> > software codecs produce them.
> > The answer was yes, so this patch adds them and the P01x formats.
>
> I tested this with the Gstreamer MR from 1 and can confirm that the
> formats P010, P012, P016, S010 and S012 work as expected.
>
> Unfortunately S016 is not supported by Gstreamer yet - however chances
> seem high that it works as well.
>
> Thus the series is:
>
> Tested-by: Robert Mader <robert.mader@collabora.com>

Thanks for testing.

In combination with my MR to libdrm/modetest to support these
formats[1], I'm happy that S016 works.
Your testing through Gstreamer gives me confidence that I haven't
messed up both my kernel patch and modetest setup in the same way :-)

Thanks again
  Dave

[1] https://gitlab.freedesktop.org/mesa/libdrm/-/merge_requests/425

> 1: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8540
>
> >
> > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> > ---
> > Changes in v2:
> > - Swapped from adding an extra bool hvs6_only to having a min_gen for
> >    each format (suggested by Maíra)
> > - Link to v1: https://lore.kernel.org/r/20250724-drm-vc4-extra-formats-v1-1-67fa80597fad@raspberrypi.com
> >
> > ---
> > Dave Stevenson (2):
> >        drm/vc4: plane: Flag formats as having a minimum generation
> >        drm/vc4: plane: Add support for P01[026] and S01[026] formats
> >
> >   drivers/gpu/drm/vc4/vc4_plane.c | 56 +++++++++++++++++++++++++++++++++++------
> >   drivers/gpu/drm/vc4/vc4_regs.h  |  9 +++++++
> >   2 files changed, 58 insertions(+), 7 deletions(-)
> > ---
> > base-commit: d2b48f2b30f25997a1ae1ad0cefac68c25f8c330
> > change-id: 20250724-drm-vc4-extra-formats-1f53e6491cc1
> >
> > Best regards,
>
> --
> Robert Mader
> Consultant Software Developer
>
> Collabora Ltd.
> Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
> Registered in England & Wales, no. 5513718
>