[v3] serial: 8250_platform: Reduce stack usage in probe functions

[PATCH v3 0/2] serial: 8250_platform: Reduce stack usage in probe functions

Posted by Abinash Singh 1 month, 4 weeks ago

On Wed, 6 Aug 2025 23:39 Andy Shevchenko wrote:
> Have you had a chance to see Arnd's comments?
>
Yeah ,I have made comments on that.
Please check that and provide feedback.

Hi,
Apologies for not reviewing the patch carefully before submitting it.
It's 3 A.M. here, and I’m still up, so I missed it


Changes in v3:
- fix missing __free(kfree)
- mixed defination with code for cleanup attribute

And I will remember the rule of thumb to mix the code and defination
in such cases.

Thank you very much !

Best regards,
Abinash

Abinash Singh (2):
  serial: 8250_platform: Reduce stack usage in serial8250_probe_acpi()
  serial: 8250_platform: Reduce stack usage in
    serial8250_probe_platform()

 drivers/tty/serial/8250/8250_platform.c | 87 +++++++++++++------------
 1 file changed, 46 insertions(+), 41 deletions(-)

-- 
2.50.1

Re: [PATCH v3 0/2] serial: 8250_platform: Reduce stack usage in probe functions

Posted by Andy Shevchenko 1 month, 3 weeks ago

On Thu, Aug 07, 2025 at 03:21:32AM +0530, Abinash Singh wrote:
> On Wed, 6 Aug 2025 23:39 Andy Shevchenko wrote:
> > Have you had a chance to see Arnd's comments?
> >
> Yeah ,I have made comments on that.
> Please check that and provide feedback.
> 
> Hi,
> Apologies for not reviewing the patch carefully before submitting it.
> It's 3 A.M. here, and I’m still up, so I missed it

If others are okay with this intermediate step,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko