On Thu, Aug 07, 2025 at 09:26:55AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Aug 06, 2025 at 06:05:07PM +0300, Laurentiu Palcu wrote:
> > Hi,
> >
> > This patch-set adds support for the i.MX94 Display Control Interface.
> > It depends on Peng Fan's DTS patch [1] that was not yet merged. Also, it
> > needs the BLK CTL changes [2] that I spinned off from v2 in a different
> > patchset.
> >
> > Also, included in the patch-set are a few extra patches that the DCIF
> > driver depends on for functioning properly:
> > * 1/9 - 3/9 : add support for i.MX94 to fsl-ldb driver. It also
> > contains a patch (2/9) from Liu Ying that was already reviewed
> > and was part of another patch-set ([3]), but was never merged;
> >
> > v3:
> > * Removed the BLK CTL patches and created a separate patch set [2] for them;
> > * Collected r-b tags for 1/9, 2/9, 3/9 and 9/9;
> > * Removed the DCIF QoS functionality until I find a better way to
> > implement it through syscon. QoS functionality will be added in
> > subsequent patches. Also, used devm_clk_bulk_get_all() and used
> > dev_err_probe() as suggested;
> > * Addressed Frank's and Krzysztof's comments on the DCIF bindings;
>
> What exactly changed?
I removed the redundant text in the description of interrupts, to make
the text fit on the same line with "description:" and, also, removed the
description items for clocks as they're pretty much explained by the
clock-names.
> I cannot find v2 of one of the patches, no lore links here, so with
> incomplete changelog I say you make it difficult for me to review it.
I'm sorry about that. :/ I am aware that removing or adding patches to
the set will most likely mess up with various tools... However, I stated
in the last line of the v3 changelog that 6/9 was new: "Added a new
binding patch, 6/9, for adding 'ldb' optional property to
nxp,imx95-blk-ctl.yaml".
Thanks,
Laurentiu
>
> Best regards,
> Krzysztof
>