drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc()

[PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc()

Posted by Liu Ying 6 months ago

devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a
NULL pointer, so use IS_ERR() to check the returned pointer and
turn proper error code on failure by using PTR_ERR().

Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c b/drivers/gpu/drm/bridge/waveshare-dsi.c
index 01c70e7d3d3b..43f4e7412d72 100644
--- a/drivers/gpu/drm/bridge/waveshare-dsi.c
+++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
@@ -147,8 +147,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
 	int ret;
 
 	ws = devm_drm_bridge_alloc(dev, struct ws_bridge, bridge, &ws_bridge_bridge_funcs);
-	if (!ws)
-		return -ENOMEM;
+	if (IS_ERR(ws))
+		return PTR_ERR(ws);
 
 	ws->dev = dev;
 
-- 
2.34.1

Re: [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc()

Posted by Liu Ying 4 months, 3 weeks ago

On 8/6/25 16:41, Liu Ying wrote:
> devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a
> NULL pointer, so use IS_ERR() to check the returned pointer and
> turn proper error code on failure by using PTR_ERR().
> 
> Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
>  drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to misc/kernel.git (drm-misc-next-fixes).

-- 
Regards,
Liu Ying

Re: [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc()

Posted by Dmitry Baryshkov 4 months, 3 weeks ago

On Wed, Aug 06, 2025 at 04:41:21PM +0800, Liu Ying wrote:
> devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a
> NULL pointer, so use IS_ERR() to check the returned pointer and
> turn proper error code on failure by using PTR_ERR().
> 
> Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
>  drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc()

Posted by Liu Ying 5 months ago

On 8/6/25 16:41, Liu Ying wrote:
> devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a
> NULL pointer, so use IS_ERR() to check the returned pointer and
> turn proper error code on failure by using PTR_ERR().
> 
> Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
>  drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Gentle ping for review.

> 
> diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c b/drivers/gpu/drm/bridge/waveshare-dsi.c
> index 01c70e7d3d3b..43f4e7412d72 100644
> --- a/drivers/gpu/drm/bridge/waveshare-dsi.c
> +++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
> @@ -147,8 +147,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
>  	int ret;
>  
>  	ws = devm_drm_bridge_alloc(dev, struct ws_bridge, bridge, &ws_bridge_bridge_funcs);
> -	if (!ws)
> -		return -ENOMEM;
> +	if (IS_ERR(ws))
> +		return PTR_ERR(ws);
>  
>  	ws->dev = dev;
>  

-- 
Regards,
Liu Ying

Re: [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc()

Posted by Liu Ying 4 months, 3 weeks ago

On 09/05/2025, Liu Ying wrote:
> On 8/6/25 16:41, Liu Ying wrote:
>> devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a
>> NULL pointer, so use IS_ERR() to check the returned pointer and
>> turn proper error code on failure by using PTR_ERR().
>>
>> Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
>> Signed-off-by: Liu Ying <victor.liu@nxp.com>
>> ---
>>  drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Gentle ping for review.

Ping again.

> 
>>
>> diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c b/drivers/gpu/drm/bridge/waveshare-dsi.c
>> index 01c70e7d3d3b..43f4e7412d72 100644
>> --- a/drivers/gpu/drm/bridge/waveshare-dsi.c
>> +++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
>> @@ -147,8 +147,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
>>  	int ret;
>>  
>>  	ws = devm_drm_bridge_alloc(dev, struct ws_bridge, bridge, &ws_bridge_bridge_funcs);
>> -	if (!ws)
>> -		return -ENOMEM;
>> +	if (IS_ERR(ws))
>> +		return PTR_ERR(ws);
>>  
>>  	ws->dev = dev;
>>  
> 


-- 
Regards,
Liu Ying