[PATCH] selftests/drivers/net: replace typeof() with __auto_type

Pranav Tyagi posted 1 patch 1 month, 4 weeks ago
tools/testing/selftests/drivers/net/hw/iou-zcrx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] selftests/drivers/net: replace typeof() with __auto_type
Posted by Pranav Tyagi 1 month, 4 weeks ago
Replace typeof() with __auto_type in iou-zcrx.c.
__auto_type was introduced in GCC 4.9 and reduces the compile time for
all compilers. No functional changes intended.

Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
---
 tools/testing/selftests/drivers/net/hw/iou-zcrx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
index 62456df947bc..85551594bf0f 100644
--- a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
+++ b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
@@ -42,8 +42,8 @@ static long page_size;
 #define SEND_SIZE (512 * 4096)
 #define min(a, b) \
 	({ \
-		typeof(a) _a = (a); \
-		typeof(b) _b = (b); \
+		__auto_type _a = (a); \
+		__auto_type _b = (b); \
 		_a < _b ? _a : _b; \
 	})
 #define min_t(t, a, b) \
-- 
2.49.0
Re: [PATCH] selftests/drivers/net: replace typeof() with __auto_type
Posted by Jakub Kicinski 1 month, 4 weeks ago
On Wed,  6 Aug 2025 13:50:16 +0530 Pranav Tyagi wrote:
> Replace typeof() with __auto_type in iou-zcrx.c.
> __auto_type was introduced in GCC 4.9 and reduces the compile time for
> all compilers. No functional changes intended.

Yet another unnecessary compiler feature. Please no.
Re: [PATCH] selftests/drivers/net: replace typeof() with __auto_type
Posted by Pranav Tyagi 1 month, 4 weeks ago
On Wed, Aug 6, 2025 at 8:59 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed,  6 Aug 2025 13:50:16 +0530 Pranav Tyagi wrote:
> > Replace typeof() with __auto_type in iou-zcrx.c.
> > __auto_type was introduced in GCC 4.9 and reduces the compile time for
> > all compilers. No functional changes intended.
>
> Yet another unnecessary compiler feature. Please no.

I understand. Thanks