Add compatible string for the DisplayPort controller found on the
Qualcomm QCS8300 SoC.
Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
---
Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 2893f097df826a5f941fbb754fb4a96a1e410a70..f5930f29c91ec95e9182c7b8ee83c0549c6657cc 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -18,6 +18,7 @@ properties:
compatible:
oneOf:
- enum:
+ - qcom,qcs8300-dp
- qcom,sa8775p-dp
- qcom,sc7180-dp
- qcom,sc7280-dp
@@ -186,6 +187,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,qcs8300-dp
- qcom,sa8775p-dp
- qcom,sc7280-dp
- qcom,sc8180x-dp
--
2.34.1
On Wed, Aug 06, 2025 at 11:16:46AM +0800, Yongxing Mou wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm QCS8300 SoC. Typical comment: you've missed the explanation, why it can not use fallback. > > Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com> > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index 2893f097df826a5f941fbb754fb4a96a1e410a70..f5930f29c91ec95e9182c7b8ee83c0549c6657cc 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -18,6 +18,7 @@ properties: > compatible: > oneOf: > - enum: > + - qcom,qcs8300-dp > - qcom,sa8775p-dp > - qcom,sc7180-dp > - qcom,sc7280-dp > @@ -186,6 +187,7 @@ allOf: > compatible: > contains: > enum: > + - qcom,qcs8300-dp > - qcom,sa8775p-dp > - qcom,sc7280-dp > - qcom,sc8180x-dp > > -- > 2.34.1 > -- With best wishes Dmitry
On 2025/8/6 11:46, Dmitry Baryshkov wrote: > On Wed, Aug 06, 2025 at 11:16:46AM +0800, Yongxing Mou wrote: >> Add compatible string for the DisplayPort controller found on the >> Qualcomm QCS8300 SoC. > > > Typical comment: you've missed the explanation, why it can not use > fallback. > Hi, Dmitry, we move this explanation to DP controller patch (patch 6). There we provide a detailed explanation of the DP controller,why we need this compatible, and why not use fallback. Thanks. >> >> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com> >> --- >> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> index 2893f097df826a5f941fbb754fb4a96a1e410a70..f5930f29c91ec95e9182c7b8ee83c0549c6657cc 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> @@ -18,6 +18,7 @@ properties: >> compatible: >> oneOf: >> - enum: >> + - qcom,qcs8300-dp >> - qcom,sa8775p-dp >> - qcom,sc7180-dp >> - qcom,sc7280-dp >> @@ -186,6 +187,7 @@ allOf: >> compatible: >> contains: >> enum: >> + - qcom,qcs8300-dp >> - qcom,sa8775p-dp >> - qcom,sc7280-dp >> - qcom,sc8180x-dp >> >> -- >> 2.34.1 >> >
On Wed, Aug 06, 2025 at 12:07:55PM +0800, Yongxing Mou wrote: > > > On 2025/8/6 11:46, Dmitry Baryshkov wrote: > > On Wed, Aug 06, 2025 at 11:16:46AM +0800, Yongxing Mou wrote: > > > Add compatible string for the DisplayPort controller found on the > > > Qualcomm QCS8300 SoC. > > > > > > Typical comment: you've missed the explanation, why it can not use > > fallback. > > > Hi, Dmitry, we move this explanation to DP controller patch (patch 6). There > we provide a detailed explanation of the DP controller,why we need this > compatible, and why not use fallback. Thanks. They are different patches, reviewed by different people. C&P might be helpful enough. > > > > > > Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com> > > > --- > > > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) -- With best wishes Dmitry
On 2025/8/6 13:09, Dmitry Baryshkov wrote: > They are different patches, reviewed by different people. C&P might be > helpful enough. Got it, thanks, will update in next version.
© 2016 - 2025 Red Hat, Inc.