[PATCH RFC v2 0/3] arm64: dts: qcom: sm8750: Add Iris VPU v3.5

Krzysztof Kozlowski posted 3 patches 1 month, 3 weeks ago
arch/arm64/boot/dts/qcom/sm8750-mtp.dts |   4 ++
arch/arm64/boot/dts/qcom/sm8750-qrd.dts |   4 ++
arch/arm64/boot/dts/qcom/sm8750.dtsi    | 113 ++++++++++++++++++++++++++++++++
3 files changed, 121 insertions(+)
[PATCH RFC v2 0/3] arm64: dts: qcom: sm8750: Add Iris VPU v3.5
Posted by Krzysztof Kozlowski 1 month, 3 weeks ago
Hi,

Changes in v2:
- Patch #1: Add RPMHPD_MXC (Konrad)
- Link to v1: https://lore.kernel.org/r/20250714-b4-sm8750-iris-dts-v1-0-93629b246d2e@linaro.org

RFC because depends on old series (6 months old!) which received
feedback and nothing happened since that time.  I assume author
abandoned that series, but unfortunately unmerged bindings for
qcom,sm8750-videocc block this patchset:
https://lore.kernel.org/all/20241206-sm8750_videocc-v1-0-5da6e7eea2bd@quicinc.com/

The bindings for new compatible qcom,sm8750-iris:
https://lore.kernel.org/r/20250804-sm8750-iris-v2-0-6d78407f8078@linaro.org

Best regards,
Krzysztof

---
Krzysztof Kozlowski (3):
      arm64: dts: qcom: sm8750: Add Iris VPU v3.5
      [DO NOT MERGE] arm64: dts: qcom: sm8750-mtp: Enable Iris codec
      [DO NOT MERGE] arm64: dts: qcom: sm8750-qrd: Enable Iris codec

 arch/arm64/boot/dts/qcom/sm8750-mtp.dts |   4 ++
 arch/arm64/boot/dts/qcom/sm8750-qrd.dts |   4 ++
 arch/arm64/boot/dts/qcom/sm8750.dtsi    | 113 ++++++++++++++++++++++++++++++++
 3 files changed, 121 insertions(+)
---
base-commit: 709a73d51f11d75ee2aee4f690e4ecd8bc8e9bf3
change-id: 20250714-b4-sm8750-iris-dts-ebdb5dc4ee27
prerequisite-message-id: 20241206-sm8750_videocc-v1-0-5da6e7eea2bd@quicinc.com
prerequisite-patch-id: ada17af875101625f7754335fabc909c8ab9cd20
prerequisite-patch-id: 3cb47a7c47cd96e02b5a4a05490088541f97c629
prerequisite-patch-id: 8c77b8e0c611b5e28086a456157940d773b323ab

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Re: [PATCH RFC v2 0/3] arm64: dts: qcom: sm8750: Add Iris VPU v3.5
Posted by Rob Herring (Arm) 1 month, 3 weeks ago
On Wed, 06 Aug 2025 14:38:29 +0200, Krzysztof Kozlowski wrote:
> Hi,
> 
> Changes in v2:
> - Patch #1: Add RPMHPD_MXC (Konrad)
> - Link to v1: https://lore.kernel.org/r/20250714-b4-sm8750-iris-dts-v1-0-93629b246d2e@linaro.org
> 
> RFC because depends on old series (6 months old!) which received
> feedback and nothing happened since that time.  I assume author
> abandoned that series, but unfortunately unmerged bindings for
> qcom,sm8750-videocc block this patchset:
> https://lore.kernel.org/all/20241206-sm8750_videocc-v1-0-5da6e7eea2bd@quicinc.com/
> 
> The bindings for new compatible qcom,sm8750-iris:
> https://lore.kernel.org/r/20250804-sm8750-iris-v2-0-6d78407f8078@linaro.org
> 
> Best regards,
> Krzysztof
> 
> ---
> Krzysztof Kozlowski (3):
>       arm64: dts: qcom: sm8750: Add Iris VPU v3.5
>       [DO NOT MERGE] arm64: dts: qcom: sm8750-mtp: Enable Iris codec
>       [DO NOT MERGE] arm64: dts: qcom: sm8750-qrd: Enable Iris codec
> 
>  arch/arm64/boot/dts/qcom/sm8750-mtp.dts |   4 ++
>  arch/arm64/boot/dts/qcom/sm8750-qrd.dts |   4 ++
>  arch/arm64/boot/dts/qcom/sm8750.dtsi    | 113 ++++++++++++++++++++++++++++++++
>  3 files changed, 121 insertions(+)
> ---
> base-commit: 709a73d51f11d75ee2aee4f690e4ecd8bc8e9bf3
> change-id: 20250714-b4-sm8750-iris-dts-ebdb5dc4ee27
> prerequisite-message-id: 20241206-sm8750_videocc-v1-0-5da6e7eea2bd@quicinc.com
> prerequisite-patch-id: ada17af875101625f7754335fabc909c8ab9cd20
> prerequisite-patch-id: 3cb47a7c47cd96e02b5a4a05490088541f97c629
> prerequisite-patch-id: 8c77b8e0c611b5e28086a456157940d773b323ab
> 
> Best regards,
> --
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 709a73d51f11d75ee2aee4f690e4ecd8bc8e9bf3
 Deps: looking for dependencies matching 3 patch-ids
 Deps: Applying prerequisite patch: [PATCH 1/3] clk: qcom: branch: Extend invert logic for branch2 mem clocks
 Deps: Applying prerequisite patch: [PATCH 2/3] dt-bindings: clock: qcom: Add SM8750 video clock controller
 Deps: Applying prerequisite patch: [PATCH 3/3] clk: qcom: videocc-sm8750: Add video clock controller driver for SM8750

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250806-b4-sm8750-iris-dts-v2-0-2ce197525eed@linaro.org:

arch/arm64/boot/dts/qcom/sm8750-mtp.dtb: /soc@0/video-codec@aa00000: failed to match any schema with compatible: ['qcom,sm8750-iris']
arch/arm64/boot/dts/qcom/sm8750-mtp.dtb: clock-controller@aaf0000 (qcom,sm8750-videocc): 'required-opps' is a required property
	from schema $id: http://devicetree.org/schemas/clock/qcom,sm8450-videocc.yaml#
arch/arm64/boot/dts/qcom/sm8750-qrd.dtb: /soc@0/video-codec@aa00000: failed to match any schema with compatible: ['qcom,sm8750-iris']
arch/arm64/boot/dts/qcom/sm8750-qrd.dtb: clock-controller@aaf0000 (qcom,sm8750-videocc): 'required-opps' is a required property
	from schema $id: http://devicetree.org/schemas/clock/qcom,sm8450-videocc.yaml#
Re: [PATCH RFC v2 0/3] arm64: dts: qcom: sm8750: Add Iris VPU v3.5
Posted by Bjorn Andersson 1 month, 3 weeks ago
On Wed, Aug 06, 2025 at 09:40:29AM -0500, Rob Herring (Arm) wrote:
> On Wed, 06 Aug 2025 14:38:29 +0200, Krzysztof Kozlowski wrote:
[..]
> arch/arm64/boot/dts/qcom/sm8750-qrd.dtb: /soc@0/video-codec@aa00000: failed to match any schema with compatible: ['qcom,sm8750-iris']
> arch/arm64/boot/dts/qcom/sm8750-qrd.dtb: clock-controller@aaf0000 (qcom,sm8750-videocc): 'required-opps' is a required property
> 	from schema $id: http://devicetree.org/schemas/clock/qcom,sm8450-videocc.yaml#

Can anyone help me understand why required-opps is a required property
in the videocc binding?

Is there a valid level below "low_svs" that is otherwise selected, but
insufficient to keep the clock controller ticking?

Regards,
Bjorn
Re: [PATCH RFC v2 0/3] arm64: dts: qcom: sm8750: Add Iris VPU v3.5
Posted by Neil Armstrong 1 month, 3 weeks ago
On 11/08/2025 18:15, Bjorn Andersson wrote:
> On Wed, Aug 06, 2025 at 09:40:29AM -0500, Rob Herring (Arm) wrote:
>> On Wed, 06 Aug 2025 14:38:29 +0200, Krzysztof Kozlowski wrote:
> [..]
>> arch/arm64/boot/dts/qcom/sm8750-qrd.dtb: /soc@0/video-codec@aa00000: failed to match any schema with compatible: ['qcom,sm8750-iris']
>> arch/arm64/boot/dts/qcom/sm8750-qrd.dtb: clock-controller@aaf0000 (qcom,sm8750-videocc): 'required-opps' is a required property
>> 	from schema $id: http://devicetree.org/schemas/clock/qcom,sm8450-videocc.yaml#
> 
> Can anyone help me understand why required-opps is a required property
> in the videocc binding?

Tee DT changes are to be picked, see https://lore.kernel.org/all/0a6baf09-b1b8-4573-b53d-574838efd9ec@quicinc.com/

I asked for them to be re-sent, but no...

Neil

> 
> Is there a valid level below "low_svs" that is otherwise selected, but
> insufficient to keep the clock controller ticking?
> 
> Regards,
> Bjorn