[PATCH v3 0/2] perf/s390: Regression: Move uid filtering to BPF filters

Ilya Leoshkevich posted 2 patches 2 months ago
tools/lib/bpf/libbpf.c       | 13 ++++++++-----
tools/lib/bpf/libbpf.h       |  4 +++-
tools/perf/util/bpf-filter.c |  5 ++++-
3 files changed, 15 insertions(+), 7 deletions(-)
[PATCH v3 0/2] perf/s390: Regression: Move uid filtering to BPF filters
Posted by Ilya Leoshkevich 2 months ago
v2: https://lore.kernel.org/bpf/20250728144340.711196-1-tmricht@linux.ibm.com/
v2 -> v3: Use no_ioctl_enable in perf.

v1: https://lore.kernel.org/bpf/20250725093405.3629253-1-tmricht@linux.ibm.com/
v1 -> v2: Introduce no_ioctl_enable (Jiri).

Hi,

This series fixes a regression caused by moving UID filtering to BPF.
The regression affects all events that support auxiliary data, most
notably, "cycles" events on s390, but also PT events on Intel. The
symptom is missing events when UID filtering is enabled.

Patch 1 introduces a new option for the
bpf_program__attach_perf_event_opts() function.
Ppatch 2 makes use of it in perf, and also contains a lot of technical
details of why exactly the prolblem is occurring.

Thanks to Thomas Richter for the investigation and the initial version
of this fix, and to Jiri Olsa for suggestions.

Best regards,
Ilya

Ilya Leoshkevich (2):
  libbpf: Add the ability to suppress perf event enablement
  perf bpf-filter: Enable events manually

 tools/lib/bpf/libbpf.c       | 13 ++++++++-----
 tools/lib/bpf/libbpf.h       |  4 +++-
 tools/perf/util/bpf-filter.c |  5 ++++-
 3 files changed, 15 insertions(+), 7 deletions(-)

-- 
2.50.1
Re: [PATCH v3 0/2] perf/s390: Regression: Move uid filtering to BPF filters
Posted by Thomas Richter 2 months ago
On 8/5/25 14:54, Ilya Leoshkevich wrote:
> v2: https://lore.kernel.org/bpf/20250728144340.711196-1-tmricht@linux.ibm.com/
> v2 -> v3: Use no_ioctl_enable in perf.
> 
> v1: https://lore.kernel.org/bpf/20250725093405.3629253-1-tmricht@linux.ibm.com/
> v1 -> v2: Introduce no_ioctl_enable (Jiri).
> 
> Hi,
> 
> This series fixes a regression caused by moving UID filtering to BPF.
> The regression affects all events that support auxiliary data, most
> notably, "cycles" events on s390, but also PT events on Intel. The
> symptom is missing events when UID filtering is enabled.
> 
> Patch 1 introduces a new option for the
> bpf_program__attach_perf_event_opts() function.
> Ppatch 2 makes use of it in perf, and also contains a lot of technical

Typo Patch

> details of why exactly the prolblem is occurring.

Typo problem

> 
> Thanks to Thomas Richter for the investigation and the initial version
> of this fix, and to Jiri Olsa for suggestions.
> 
> Best regards,
> Ilya
> 
> Ilya Leoshkevich (2):
>   libbpf: Add the ability to suppress perf event enablement
>   perf bpf-filter: Enable events manually
> 
>  tools/lib/bpf/libbpf.c       | 13 ++++++++-----
>  tools/lib/bpf/libbpf.h       |  4 +++-
>  tools/perf/util/bpf-filter.c |  5 ++++-
>  3 files changed, 15 insertions(+), 7 deletions(-)
> 

Thanks for taking over!!!
For the whole series

Tested-by: Thomas Richter <tmricht@linux.ibm.com>

-- 
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH

Vorsitzender des Aufsichtsrats: Wolfgang Wendt

Geschäftsführung: David Faller

Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294