LoongArch: Rename GCC_PLUGIN_STACKLEAK to KSTACK_ERASE

[PATCH] LoongArch: Rename GCC_PLUGIN_STACKLEAK to KSTACK_ERASE

Posted by Huacai Chen 6 months ago

Commit 57fbad15c2eee772 ("stackleak: Rename STACKLEAK to KSTACK_ERASE")
misses the stackframe.h part for LoongArch, so fix it.

Fixes: 57fbad15c2eee772 ("stackleak: Rename STACKLEAK to KSTACK_ERASE")
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
 arch/loongarch/include/asm/stackframe.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/loongarch/include/asm/stackframe.h b/arch/loongarch/include/asm/stackframe.h
index 3eda298702b1..5cb568a60cf8 100644
--- a/arch/loongarch/include/asm/stackframe.h
+++ b/arch/loongarch/include/asm/stackframe.h
@@ -58,7 +58,7 @@
 	.endm
 
 	.macro STACKLEAK_ERASE
-#ifdef CONFIG_GCC_PLUGIN_STACKLEAK
+#ifdef CONFIG_KSTACK_ERASE
 	bl	stackleak_erase_on_task_stack
 #endif
 	.endm
-- 
2.47.3

Re: [PATCH] LoongArch: Rename GCC_PLUGIN_STACKLEAK to KSTACK_ERASE

Posted by Kees Cook 5 months, 2 weeks ago

On Tue, 05 Aug 2025 19:07:54 +0800, Huacai Chen wrote:
> Commit 57fbad15c2eee772 ("stackleak: Rename STACKLEAK to KSTACK_ERASE")
> misses the stackframe.h part for LoongArch, so fix it.
> 
> 

Applied to for-linus/hardening, thanks!

[1/1] LoongArch: Rename GCC_PLUGIN_STACKLEAK to KSTACK_ERASE
      https://git.kernel.org/kees/c/351b51dc16a9

Take care,

-- 
Kees Cook

Re: [PATCH] LoongArch: Rename GCC_PLUGIN_STACKLEAK to KSTACK_ERASE

Posted by Huacai Chen 5 months, 2 weeks ago

On Tue, Aug 26, 2025 at 5:39 AM Kees Cook <kees@kernel.org> wrote:
>
> On Tue, 05 Aug 2025 19:07:54 +0800, Huacai Chen wrote:
> > Commit 57fbad15c2eee772 ("stackleak: Rename STACKLEAK to KSTACK_ERASE")
> > misses the stackframe.h part for LoongArch, so fix it.
> >
> >
>
> Applied to for-linus/hardening, thanks!
>
> [1/1] LoongArch: Rename GCC_PLUGIN_STACKLEAK to KSTACK_ERASE
>       https://git.kernel.org/kees/c/351b51dc16a9
Unnecessary, it is already in 6.17-rc3 via loongarch tree, thanks.

Huacai

>
> Take care,
>
> --
> Kees Cook
>
>

Re: [PATCH] LoongArch: Rename GCC_PLUGIN_STACKLEAK to KSTACK_ERASE

Posted by Kees Cook 5 months, 2 weeks ago

On Tue, Aug 26, 2025 at 10:42:52AM +0800, Huacai Chen wrote:
> On Tue, Aug 26, 2025 at 5:39 AM Kees Cook <kees@kernel.org> wrote:
> >
> > On Tue, 05 Aug 2025 19:07:54 +0800, Huacai Chen wrote:
> > > Commit 57fbad15c2eee772 ("stackleak: Rename STACKLEAK to KSTACK_ERASE")
> > > misses the stackframe.h part for LoongArch, so fix it.
> > >
> > >
> >
> > Applied to for-linus/hardening, thanks!
> >
> > [1/1] LoongArch: Rename GCC_PLUGIN_STACKLEAK to KSTACK_ERASE
> >       https://git.kernel.org/kees/c/351b51dc16a9
> Unnecessary, it is already in 6.17-rc3 via loongarch tree, thanks.

Ah-ha! Great; thanks!

-- 
Kees Cook