[PATCH] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link()

Miaoqian Lin posted 1 patch 6 months, 1 week ago
drivers/clk/rockchip/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link()
Posted by Miaoqian Lin 6 months, 1 week ago
Replace NULL check with IS_ERR_OR_NULL() check after calling
rockchip_clk_register_gate_link() since this function
returns error pointers (ERR_PTR).

Fixes: c62fa612cfa6 ("clk: rockchip: implement linked gate clock support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/clk/rockchip/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
index 19caf26c991b..2d30b1e24f01 100644
--- a/drivers/clk/rockchip/clk.c
+++ b/drivers/clk/rockchip/clk.c
@@ -693,7 +693,7 @@ void rockchip_clk_register_late_branches(struct device *dev,
 			break;
 		}
 
-		if (!pdev)
+		if (IS_ERR_OR_NULL(pdev))
 			dev_err(dev, "failed to register device for clock %s\n", list->name);
 	}
 }
-- 
2.25.1
Re: [PATCH] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link()
Posted by Heiko Stuebner 1 month ago
On Tue, 05 Aug 2025 07:03:58 +0400, Miaoqian Lin wrote:
> Replace NULL check with IS_ERR_OR_NULL() check after calling
> rockchip_clk_register_gate_link() since this function
> returns error pointers (ERR_PTR).
> 
> 

Applied, thanks!

[1/1] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link()
      commit: a8d722f03923b1c6166d39482c6df8f017e185d9

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>