rust/kernel/faux.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Starting with Rust 1.91.0 (expected 2025-10-30), `rustdoc` has improved
some false negatives around intra-doc links [1], and it found a broken
intra-doc link we currently have:
error: unresolved link to `include/linux/device/faux.h`
--> rust/kernel/faux.rs:7:17
|
7 | //! C header: [`include/linux/device/faux.h`]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `include/linux/device/faux.h` in scope
|
= help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
= note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`
Our `srctree/` C header links are not intra-doc links, thus they need
the link destination.
Thus fix it.
Cc: stable@vger.kernel.org
Link: https://github.com/rust-lang/rust/pull/132748 [1]
Fixes: 78418f300d39 ("rust/kernel: Add faux device bindings")
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
It may have been in 1.90, but the beta branch does not have it, and the
rollup PR says 1.91, unlike the PR itself, so I picked 1.91. It happened
just after the version bump to 1.91, so it may have to do with that.
rust/kernel/faux.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/faux.rs b/rust/kernel/faux.rs
index 7a906099993f..7fe2dd197e37 100644
--- a/rust/kernel/faux.rs
+++ b/rust/kernel/faux.rs
@@ -4,7 +4,7 @@
//!
//! This module provides bindings for working with faux devices in kernel modules.
//!
-//! C header: [`include/linux/device/faux.h`]
+//! C header: [`include/linux/device/faux.h`](srctree/include/linux/device/faux.h)
use crate::{bindings, device, error::code::*, prelude::*};
use core::ptr::{addr_of_mut, null, null_mut, NonNull};
base-commit: d2eedaa3909be9102d648a4a0a50ccf64f96c54f
--
2.50.1
On Mon Aug 4, 2025 at 7:13 PM CEST, Miguel Ojeda wrote: > Starting with Rust 1.91.0 (expected 2025-10-30), `rustdoc` has improved > some false negatives around intra-doc links [1], and it found a broken > intra-doc link we currently have: > > error: unresolved link to `include/linux/device/faux.h` > --> rust/kernel/faux.rs:7:17 > | > 7 | //! C header: [`include/linux/device/faux.h`] > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `include/linux/device/faux.h` in scope > | > = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]` > = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings` > = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]` > > Our `srctree/` C header links are not intra-doc links, thus they need > the link destination. > > Thus fix it. > > Cc: stable@vger.kernel.org > Link: https://github.com/rust-lang/rust/pull/132748 [1] > Fixes: 78418f300d39 ("rust/kernel: Add faux device bindings") > Signed-off-by: Miguel Ojeda <ojeda@kernel.org> Reviewed-by: Benno Lossin <lossin@kernel.org> --- Cheers, Benno > --- > It may have been in 1.90, but the beta branch does not have it, and the > rollup PR says 1.91, unlike the PR itself, so I picked 1.91. It happened > just after the version bump to 1.91, so it may have to do with that. > > rust/kernel/faux.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
On Mon, Aug 4, 2025 at 7:13 PM Miguel Ojeda <ojeda@kernel.org> wrote: > > Starting with Rust 1.91.0 (expected 2025-10-30), `rustdoc` has improved > some false negatives around intra-doc links [1], and it found a broken > intra-doc link we currently have: > > error: unresolved link to `include/linux/device/faux.h` > --> rust/kernel/faux.rs:7:17 > | > 7 | //! C header: [`include/linux/device/faux.h`] > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `include/linux/device/faux.h` in scope > | > = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]` > = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings` > = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]` > > Our `srctree/` C header links are not intra-doc links, thus they need > the link destination. > > Thus fix it. > > Cc: stable@vger.kernel.org > Link: https://github.com/rust-lang/rust/pull/132748 [1] > Fixes: 78418f300d39 ("rust/kernel: Add faux device bindings") > Signed-off-by: Miguel Ojeda <ojeda@kernel.org> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
© 2016 - 2025 Red Hat, Inc.