net/ipv4/tcp_ipv4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
This commit resolves the following checkpatch.pl error:
```
ERROR: spaces required around that '=' (ctx:VxW)
+ .twsk_destructor= tcp_twsk_destructor,
^
```
Assuming the purpose was to align the equal signs, I also added a space in
the previous line.
Signed-off-by: Osama Albahrani <osalbahr@gmail.com>
---
net/ipv4/tcp_ipv4.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 84d3d556ed80..2585e176b031 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -2458,8 +2458,8 @@ int tcp_v4_rcv(struct sk_buff *skb)
}
static struct timewait_sock_ops tcp_timewait_sock_ops = {
- .twsk_obj_size = sizeof(struct tcp_timewait_sock),
- .twsk_destructor= tcp_twsk_destructor,
+ .twsk_obj_size = sizeof(struct tcp_timewait_sock),
+ .twsk_destructor = tcp_twsk_destructor,
};
void inet_sk_rx_dst_set(struct sock *sk, const struct sk_buff *skb)
--
2.50.1
On Mon, Aug 4, 2025 at 7:39 AM Osama Albahrani <osalbahr@gmail.com> wrote: > > This commit resolves the following checkpatch.pl error: > > ``` > ERROR: spaces required around that '=' (ctx:VxW) > + .twsk_destructor= tcp_twsk_destructor, > ^ > ``` > > Assuming the purpose was to align the equal signs, I also added a space in > the previous line. > > Signed-off-by: Osama Albahrani <osalbahr@gmail.com> > --- I have a patch removing .twsk_destructor completely, waiting for net-next to open next week. (DCCP has been removed a while ago) So I would vote for not bothering with your patch.
© 2016 - 2026 Red Hat, Inc.